Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Artifacts] More detailed information for chunked uploads #957

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

konradpabjan
Copy link
Contributor

@konradpabjan konradpabjan commented Dec 6, 2021

While investigating some 503s that can occur during artifact upload, the server reports that certain chunks were missing as part of the upload. The client thinks that all chunks were uploaded so it's unclear where something could be going wrong. This PR changes a few things

  • Displays the chunks that were uploaded for all HTTP calls over 8MB (files that are smaller are not uploaded in chunks). Previously only files over 100MB would have any extra information displayed
  • Displays the chunk information after each upload call. Previously there was this largeFileStatus that was used to display information about large files every 1 second. Within a 1 second period there can be more than 1 chunk uploaded for a file so I've gotten rid of that and every single HTTP call simply gets outputted. The downside of this is that there are more logs which makes things a bit more verbose but people generally don't care about that and it's much better to display all this information for diagnostic purposes

Old output: https://github.com/konradpabjan/artifact-test/runs/4434790411?check_suite_focus=true

image

New output: https://github.com/konradpabjan/artifact-test/runs/4435915324?check_suite_focus=true

image

The new output is a bit more verbose, perhaps a bit too much but I this will help a lot in helping to diagnose weird issues where the client thinks it's uploaded everything but the server reports certain chunks are missing

@konradpabjan konradpabjan requested a review from a team December 6, 2021 20:53
@konradpabjan konradpabjan requested a review from a team December 6, 2021 20:59
@konradpabjan konradpabjan merged commit 45a3c7b into main Dec 6, 2021
at-wat pushed a commit to at-wat/actions-toolkit that referenced this pull request Aug 31, 2023
* More detailed information for chunked uploads

* Run npm format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants