Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent accidental file matching when glob contains trailing slash #805

Merged
merged 5 commits into from
May 14, 2021
Merged

Prevent accidental file matching when glob contains trailing slash #805

merged 5 commits into from
May 14, 2021

Conversation

luketomlinson
Copy link
Contributor

@luketomlinson luketomlinson commented May 11, 2021 •
edited
Loading

Resolves #628

Handles an odd case with Minimatch that we worked around before that inadvertently would match files when a trailing slash was added.

@luketomlinson luketomlinson marked this pull request as ready for review May 11, 2021 21:11
@luketomlinson luketomlinson requested a review from a team as a code owner May 11, 2021 21:11
@luketomlinson luketomlinson changed the title Draft Solution Prevent accidental file matching when glob contains trailing slash May 11, 2021
thboop
thboop approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luketomlinson luketomlinson merged commit 98549fb into main May 14, 2021
@luketomlinson luketomlinson deleted the bugfix/glob-file-matching branch May 14, 2021 18:12
@luketomlinson luketomlinson mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang left review comments

@thboop thboop thboop approved these changes

@ericsciple ericsciple ericsciple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glob: Pattern with trailing / unexpectedly matches a file.
4 participants
@luketomlinson @TingluoHuang @ericsciple @thboop