Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory filtering to globber #728

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Add directory filtering to globber #728

merged 2 commits into from
Jun 1, 2021

Conversation

MatisseHack
Copy link
Contributor

This adds a new option to only return file matches for a given glob pattern and skip any directories. I often find myself filtering directories out of the final results with subsequent fs calls and this change would streamline that process.

By default, the current behavior is maintained, but passing the new { matchDirectories: false } option prevents the globber from returning directory matches.

@MatisseHack MatisseHack requested a review from a team as a code owner March 2, 2021 07:51
@thboop thboop added the glob label May 28, 2021
@thboop
Copy link
Collaborator

thboop commented Jun 1, 2021

@MatisseHack thanks for the contribution! 🚀 🚀 🚀

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants