Update octokit graphql type dependencies #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hross
commented
Nov 22, 2019
|
Looks like this will break the contract for graphQL a bit, but then again the octokit already broke that contract on update. I did the following to test the changes:
TLDR: this might change the contract when we republish a new version, but I think that is OK. |
hross
force-pushed
the
update_graphql
branch
from
5260f27
to
45f087f
Compare
hross
changed the title
hross
force-pushed
the
update_graphql
branch
from
6ad1418
to
dacac6f
Compare
hross
commented
Nov 26, 2019
thboop
reviewed
Nov 26, 2019
hross
commented
Nov 26, 2019
hross
commented
Nov 26, 2019
hross
commented
Nov 26, 2019
hross
force-pushed
the
update_graphql
branch
from
9ef773f
to
986e32e
Compare
ericsciple
approved these changes
Dec 3, 2019
|
We will want to update Releases.MD before the release. |
Bullrich
added a commit
to Bullrich/Prace.js
that referenced
this pull request
Jan 14, 2022
## System changed - Dependency versions - Build ## Description Updated packages to latest version to support new features available in GitHub Actions, including GitHub enterprise edition (this PR brings that new functionality: actions/toolkit#794). Some dependency types have changed and they have been updated to the new types. The `octokitHack.ts` file is no longer needed as that bug has been fixed: actions/toolkit#228 The build directory has been recreated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix attempts to address the issue with custom type definitions here: #199