Skip to content

tool-cache: Work around a weird GNU Tar behavior on Windows #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ecco wants to merge 1 commit into from
Closed

tool-cache: Work around a weird GNU Tar behavior on Windows #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/tool-cache/src/tool-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,10 @@ export async function extractTar(
}

dest = dest || (await _createExtractFolder(dest))
if (IS_WINDOWS) {
// For some reason, GNU Tar on Windows expects paths to be slash-separated even though this is not the standard Windows path delimiter
dest = dest.replace(/\\/g, '/')
Copy link
Contributor

@ericsciple ericsciple Dec 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed an alternate solution for #165 which will eliminate the need for this.

Let's close on the other PR first before proceeding with this PR.

}
const tarPath: string = await io.which('tar', true)
await exec(`"${tarPath}"`, [flags, '-C', dest, '-f', file])

Expand Down