Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/exec: add timeout option to exec function #1778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 28, 2024

Fixes #1777

@rhysd rhysd requested a review from a team as a code owner July 28, 2024 10:15
@rhysd
Copy link
Contributor Author

rhysd commented Jul 28, 2024

The test on macOS failed but the failure seems not related to this PR's change:

Summary of all failing tests
FAIL packages/http-client/__tests__/basics.test.ts (5.499 s)
  ● basics › does basic http post request

    expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 502

      252 |       b
      253 |     )
    > 254 |     expect(res.message.statusCode).toBe(200)
          |                                    ^
      255 |     const body: string = await res.readBody()
      256 |     const obj = JSON.parse(body)
      257 |     expect(obj.data).toBe(b)

      at packages/http-client/__tests__/basics.test.ts:254:36
      at fulfilled (packages/http-client/__tests__/basics.test.ts:29:58)


Test Suites: 1 failed, 50 passed, 51 total
Tests:       1 failed, 572 passed, 573 total

https://github.com/actions/toolkit/actions/runs/10130893260/job/28012870699?pr=1778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actions/exec: Allow timeout on running a process
1 participant