Removing childprocess for rmRF #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vmjoseph
commented
Mar 14, 2023
•
vmjoseph
commented
- Uses node's rm instead of custom rmRF logic
- Fixes locked file tests
- Removes symlink tests for windows specific cases
vmjoseph
force-pushed
the
users/vmjoseph/rmrf-windows
branch
from
67155c8
to
a730b5c
Compare
cory-miller
approved these changes
Mar 15, 2023
packages/io/__tests__/io.test.ts
Outdated
| await assertNotExists(testPath) | ||
| // for windows, we need to explicitly set an exlcusive lock | ||
| // or we won't get an EBUSY error. this can be fixed after | ||
| // https://github.com/libuv/libuv/issues/3267 is resolved |
There was a problem hiding this comment.
Can you move this inside the try statement? It's about the EPERM comment. I don't think Node considers its fs.open call not creating a lock on Windows a bug.
Co-authored-by: Cory Miller <[email protected]>
Co-authored-by: Cory Miller <[email protected]>
jww3
reviewed
Mar 15, 2023
cory-miller
reviewed
Mar 15, 2023
Co-authored-by: Cory Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.