Skip to content

Cache package release for compression change in windows - #1281

Merged
Phantsure merged 58 commits into
mainfrom
phantsure/compression-changes-release
Dec 22, 2022
Merged

Cache package release for compression change in windows#1281
Phantsure merged 58 commits into
mainfrom
phantsure/compression-changes-release

Conversation

@Phantsure

@Phantsure Phantsure commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

This branch has changes related to compression on windows. Add

  1. Change default archiver to GNU tar and compression algorithm to zstd on windows
  2. Allowed fallback to BSD tar and zstd in case GNU tar is not present in path or at default location on windows.
  3. Allowed fallback to old caching archiving-compression algorithm, i.e. BSD tar and gzip if old cache on windows is found.

lvpx and others added 30 commits November 16, 2022 20:18
@lvpx
bsd + zstd fallback implementation
6349c3c
@lvpx
bsd + zstd fallback implementation
db3517f
@lvpx
Fix tar operations
27bf830
@lvpx
Add -v option for testing
e9e146b
@lvpx
Fix order of args for tar
5f89653
@Phantsure
Add GNUtar as default on windows
6f7397f
@Phantsure
Fix test
964682b
@Phantsure
Merge pull request #1239 from actions/phantsure/gnutar_windows
caadeee 
Add GNUtar as default on windows
@lvpx
Fix tar tests
ea98560
@lvpx
Fix lint issues
4fa5b7d
@lvpx
Fix windows gnutar test case
b3bd482
@lvpx
Temporarily remove thhe condition that prevents zstd usage on windows…
f9dfb05 
… unless with GNUtar
@Phantsure
Address some comments and correct compression commands
54eb9b8
@Phantsure
Add windows bsdtar test
32b9582
@Phantsure
Fix windows test
32f5381
@Phantsure
Fix test
ffde3e4
@Phantsure
Separate args
2f73afa
@Phantsure
Fix old tests
39b7a86
@Phantsure
Add new tests
1f33717
@Phantsure
Fix tests
187781e
@Phantsure
Fix lint test
0822441
@Phantsure
Refactor code
0fd856d
@Phantsure
Address review comments
34f0143
@Phantsure
Fix test
2e5a517
@Phantsure
Fix tar test
424ae62
@Phantsure
Add await to async function calls
afbc5c0
@Phantsure
Fix test
8595831
@Phantsure
Merge pull request #1237 from actions/pdotl/win-bsdtar-zstd
785599d 
Bsdtar + zstd fallback to prevent zstd hanging issue on windows
@Phantsure
Update for beta release
c207fbd
@Phantsure
Fix audit issues
61e6308
Phantsure and others added 14 commits December 12, 2022 07:04
@Phantsure
Fix test
bbf5659
@Phantsure
Fix test
6bc5dc5
@Phantsure
Fix tests
d7ae8cd
@Phantsure
Add better comments
cad074c
@Phantsure Bishal Prasad
Update packages/cache/src/internal/cacheHttpClient.ts
e7e1984 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@Phantsure
Address review comments
2d3c79e
@Phantsure
Merge pull request #1260 from actions/phantsure/cache-testing
8b695c1 
Fix known issues for cache
@Phantsure
Update for new beta cache package release
0ff35ed
@Phantsure
Address bugbash issues
a20e7c1
@Phantsure
Fix tests
8e69225
@Phantsure
Merge pull request #1279 from actions/phantsure/bug-bash
c24b93f 
Address bugbash issues
@Phantsure
Merge branch 'releases/cache-v3-beta' of https://github.com/actions/t…
3959b79 
…oolkit into releases/cache-v3-beta
@Phantsure
Merge branch 'main' of https://github.com/actions/toolkit into releas…
fd47902 
…es/cache-v3-beta
@Phantsure
Release new actions/cache minor version
c76b5b3
@Phantsure
Phantsure marked this pull request as ready for review December 22, 2022 07:39
@Phantsure
Phantsure requested review from a team as code owners December 22, 2022 07:39
lvpx
lvpx suggested changes Dec 22, 2022
View reviewed changes
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Comment thread packages/cache/src/internal/tar.ts
Phantsure
Phantsure commented Dec 22, 2022
View reviewed changes
Comment thread packages/cache/src/internal/tar.ts
@Phantsure
Phantsure force-pushed the phantsure/compression-changes-release branch from 58f03e1 to 00f4563 Compare December 22, 2022 12:41
lvpx
lvpx approved these changes Dec 22, 2022
View reviewed changes

@lvpx lvpx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phantsure
Phantsure force-pushed the phantsure/compression-changes-release branch from 00f4563 to c76b5b3 Compare December 22, 2022 12:55
@Phantsure
Phantsure merged commit b228732 into main Dec 22, 2022
@blaggacao

blaggacao commented Dec 23, 2022 •
edited
Loading

Copy link
Copy Markdown

Does this PR mean that the following cache keys:

    path: |
      /nix
      /guix

Are now restored to GITHUB_WORKSPACE and we need to post-process to move it into the right place?

post-process

That would be quite costly. ⌛

See also: #1253

@blaggacao blaggacao mentioned this pull request Dec 23, 2022
Open
Phantsure added a commit that referenced this pull request Dec 27, 2022
@Phantsure
Revert "Cache package release for compression change in windows (#1281)"
85bd49f 
This reverts commit b228732.
@Phantsure Phantsure mentioned this pull request Dec 27, 2022
Merged
Phantsure added a commit that referenced this pull request Dec 27, 2022
@Phantsure
Revert "Cache package release for compression change in windows" (#1289)
86fe4ab 
* Revert "Cache package release for compression change in windows (#1281)"

This reverts commit b228732.

* Update release version to patch
@Phantsure Phantsure mentioned this pull request Dec 29, 2022
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lvpx lvpx lvpx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phantsure @blaggacao @lvpx