Add GNUtar as default in windows - #1232
Merged
Merged
Conversation
Phantsure
force-pushed
the
phantsure/gnutar_windows
branch
from
November 10, 2022 15:52
ff3291a to
436cf8d
Compare
Phantsure
marked this pull request as ready for review
November 14, 2022 05:25
Phantsure
commented
Nov 14, 2022
Phantsure
commented
Nov 14, 2022
This reverts commit 4b34808.
lvpx
reviewed
Nov 14, 2022
lvpx
approved these changes
Nov 14, 2022
lvpx
left a comment
lvpx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. A minor comment related to imports. Please take care of failing test cases other than the audit one.
Contributor
Author
|
Done |
Phantsure
commented
Nov 15, 2022
bishal-pdMSFT
approved these changes
Nov 15, 2022
This was referenced Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNUtar is present in windows hosted runners to default to it for archiving