Add Indeni Cloudrail #1047
Merged
Add Indeni Cloudrail #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
code-scanning
Ashleycho35
approved these changes
Aug 27, 2021
nickfyson
suggested changes
Sep 27, 2021
There was a problem hiding this comment.
Thanks for this PR, and apologies it's taken a while for you to get a review!
The tile is looking good...
In line with our other workflows, though, I've proposed a few edits to the description (to keep it a bit shorter).
Other than that, just a change to add full SHA pinning.
Co-authored-by: Nick Fyson <[email protected]>
|
@nickfyson thank you for the comments and apologize for the delay in my response, please take another look now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Not clear on how to test this. Our GitHub Action is well tested, of course.