Skip to content

Bump form-data to bring in fix for critical vulnerability - #1277

Merged
v-HarithaVattikuti merged 1 commit into
actions:mainfrom
v-gowridurgad:bumps-form-data
Jul 31, 2025
Merged

v-HarithaVattikuti merged 1 commit into
actions:mainfrom
v-gowridurgad:bumps-form-data

Conversation

@v-gowridurgad

@v-gowridurgad v-gowridurgad commented Jul 30, 2025 •

Copy link
Copy Markdown
Contributor

This PR upgrades the form-data dependency to version 4.0.4 using npm audit fix, resolving a critical security vulnerability identified as CVE-2025-7783.

Vulnerability Summary:
form-data previously used Math.random() to generate boundary values for multipart form-encoded data. Because Math.random() is a pseudo-random number generator, it can be predicted if an attacker:

Can observe outputs of Math.random() in the application (e.g., via request headers), and

Can control at least one field in a form-data request.

This predictability allows an attacker to guess the multipart boundary, enabling them to inject additional fields or override values in downstream requests, leading to potential manipulation of internal services.

Affected Package:
Package: form-data

Vulnerable Versions: < 2.5.4

Fixed Version: >= 2.5.4 (current version after fix: 4.0.4)

Resolution:
This PR brings in the fix by allowing npm audit fix to bump the form-data version to 4.0.4, which no longer uses Math.random() and includes proper randomization for multipart boundaries.

Related issue:
dependabot alert #34
dependabot alert #35

Copilot AI review requested due to automatic review settings July 30, 2025 07:13
@v-gowridurgad
v-gowridurgad requested a review from a team as a code owner July 30, 2025 07:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the form-data dependency to address CVE-2025-7783, a critical security vulnerability where form-data used predictable Math.random() values for multipart boundary generation, allowing potential field injection attacks.

  • Upgrades form-data from versions 2.5.1/4.0.0 to 2.5.5/4.0.4 to fix the vulnerability
  • Updates license tracking files for new transitive dependencies introduced by the upgrade
  • Resolves security issue where attackers could predict multipart boundaries and manipulate form data

Reviewed Changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.

File Description
.licenses/npm/form-data-4.0.4.dep.yml Updates form-data version from 4.0.0 to 4.0.4 and corrects README filename
.licenses/npm/form-data-2.5.5.dep.yml Updates form-data version from 2.5.1 to 2.5.5
.licenses/npm/brace-expansion.dep.yml Updates brace-expansion dependency version from 1.1.11 to 1.1.12
Multiple new .dep.yml files Adds license tracking for new transitive dependencies introduced by the upgrade

@v-HarithaVattikuti
v-HarithaVattikuti merged commit 8f717f0 into actions:main Jul 31, 2025
jayudey-wf pushed a commit to jayudey-wf/stale that referenced this pull request Dec 4, 2025
Co-authored-by: “gowridurgad” <“hgowridurgad@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants