Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

First attempt at find ruby action #1

Merged
merged 4 commits into from
Jun 27, 2019
Merged

First attempt at find ruby action #1

merged 4 commits into from
Jun 27, 2019

Conversation

dmarcey
Copy link
Contributor

@dmarcey dmarcey commented Jun 27, 2019

No description provided.

damccorm
damccorm reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. Added a couple comments, fleshing out tests a little would be good too. See here for some examples of good things to be testing (ignoring the installation stuff of course)

action.yml Outdated Show resolved Hide resolved
src/find-ruby.ts Outdated Show resolved Hide resolved
src/find-ruby.ts Outdated Show resolved Hide resolved
@dmarcey dmarcey merged commit edbe0e4 into master Jun 27, 2019
@dmarcey dmarcey deleted the features/getRubyVersion branch July 1, 2019 15:34
@bryanmacfarlane bryanmacfarlane mentioned this pull request Jan 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damccorm damccorm damccorm left review comments

Assignees

@damccorm damccorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarcey @damccorm