Automatic discovery of version matching package.json engines #467
Labels
feature request
New feature or request to improve the current logic
Comments
ad-m-ss
added
feature request
|
Hi @ad-m-ss, We will investigate the possibility of adding this feature. |
|
++ this is exactly what i was looking for having the ability to say node-version: package would be a good solution i think. |
|
There is something like this implemented in https://github.com/pkgjs/action |
2 tasks
2 tasks
|
Hello everyone. We released a new version with support for engines.node. You can try to specify package.json for |
|
@dmitry-shibanov it worked for me! Thanks! |
|
Hello everyone. I'm going to close the issue because we're not planing to enable it by default for now. The action supports getting version from different sources and it can be confusing to enable one of them by default for now. |
rngadam
added a commit
to rngadam/setup-node
that referenced
this issue
Jul 28, 2023
deining
pushed a commit
to deining/setup-node
that referenced
this issue
Nov 9, 2023
* Add how to autodetect deleted files The existing instructions make sense for when a predetermined list of files need to be removed. This is likely not a common use case so I shortened that explanation. Also added the explanation on how to use `--no-ignore-removal` as the `add` setting to have deleted files autodetected. Fixes actions#467 * docs(README): update "Deleting files" paragraph Co-authored-by: Federico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
In my organization we pin specific version of Node in package.json via
engines.node.https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines
It therefore seems redundant to include such information in the CI.
I would prefer the action to allow - if the appropriate package.json is detected - to look in engines.node in package.json and select the latest NodeJS version that meets the specified version range. This would be complementary to the current versioning mechanism and only have an effect if the version is not specified as an action parameter.
Justification:
DRY
Are you willing to submit a PR?
I would like discuss it first.
The text was updated successfully, but these errors were encountered: