-
Notifications
You must be signed in to change notification settings - Fork 813
Add Documentation to Recommend Using GraalVM JDK 17 Version to 17.0.12 to Align with GFTC License Terms #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @aparnajyothi-y, thanks for the PR. I work on the GraalVM at Oracle and contributed GraalVM support. Instead of adding a note like this, we are using a different approach in Do you think it would make sense to do the same in |
|
Hello @fniephaus, Thank you for the suggestion. Based on further investigation, it wouldn’t be feasible to adopt the same approach for Java 17 as in setup-graalvm at this time, because the end of GFTC support for version 17.0.12 has not yet been confirmed. As a result, we cannot be certain whether this will be the final update of Java 17 with GFTC license support, or if future versions will follow the same model. Given this uncertainty, we’ve decided to update the documentation instead of implementing the same defaulting approach as in setup-graalvm. We appreciate your understanding! |
noob-code55
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Setup Java JDK
uses: actions/[email protected]
with:
# The Java version to set up. Takes a whole or semver Java version. See examples of supported syntax in README file
java-version: # optional
# The path to the .java-version file. See examples of supported syntax in README file
java-version-file: # optional
# Java distribution. See the list of supported distributions in README file
distribution:
# The package type (jdk, jre, jdk+fx, jre+fx)
java-package: # optional, default is jdk
# The architecture of the package (defaults to the action runner's architecture)
architecture: # optional
# Path to where the compressed JDK is located
jdkFile: # optional
# Set this option if you want the action to check for the latest available version that satisfies the version spec
check-latest: # optional
# ID of the distributionManagement repository in the pom.xml file. Default is github
server-id: # optional, default is github
# Environment variable name for the username for authentication to the Apache Maven repository. Default is $GITHUB_ACTOR
server-username: # optional, default is GITHUB_ACTOR
# Environment variable name for password or token for authentication to the Apache Maven repository. Default is $GITHUB_TOKEN
server-password: # optional, default is GITHUB_TOKEN
# Path to where the settings.xml file will be written. Default is ~/.m2.
settings-path: # optional
# Overwrite the settings.xml file if it exists. Default is "true".
overwrite-settings: # optional, default is true
# GPG private key to import. Default is empty string.
gpg-private-key: # optional
# Environment variable name for the GPG private key passphrase. Default is $GPG_PASSPHRASE.
gpg-passphrase: # optional
# Name of the build platform to cache dependencies. It can be "maven", "gradle" or "sbt".
cache: # optional
# The path to a dependency file: pom.xml, build.gradle, build.sbt, etc. This option can be used with the cache option. If this option is omitted, the action searches for the dependency file in the entire repository. This option supports wildcards and a list of file names for caching multiple dependencies.
cache-dependency-path: # optional
# Workaround to pass job status to post job step. This variable is not intended for manual setting
job-status: # optional, default is ${{ job.status }}
# The token used to authenticate when fetching version manifests hosted on github.com, such as for the Microsoft Build of OpenJDK. When running this action on github.com, the default value is sufficient. When running on GHES, you can pass a personal access token for github.com if you are experiencing rate limiting.
token: # optional, default is ${{ github.server_url == 'https://github.com' && github.token || '' }}
# Name of Maven Toolchain ID if the default name of "${distribution}_${java-version}" is not wanted. See examples of supported syntax in Advanced Usage file
mvn-toolchain-id: # optional
# Name of Maven Toolchain Vendor if the default name of "${distribution}" is not wanted. See examples of supported syntax in Advanced Usage file
mvn-toolchain-vendor: # optional
|
Hello @fniephaus, a gentle reminder to check if you have any further questions or need additional clarifications on the above. |
|
Thanks for the ping, @aparnajyothi-y! The blog post that introduced GFTC said the following about timelines: "For designated Long Term Support releases (GraalVM for JDK 17), Oracle will provide these free GFTC releases until one full year after the subsequent LTS release". According to the release calendar, Oracle GraalVM for JDK 17.0.12 is the last release under GFTC. The artifacts are still available and their license are not changed retroactively. In fact, the script-friendly URLs used by The end of permissive license was also announced here. So, I'd still recommend to let 'java-version: 17' fall back to 17.0.12 while displaying a warning that notifies users of their options (upgrading to JDK 21 is recommended). What do you think? |
|
Related issue: #700 |
|
Hello @fniephaus, We encourage your future feedback as we continue to improve setup-java. |
…2 to Align with GFTC License Terms (actions#704) * Update the graalvm documentation * update the documentation
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.6.0 to 5.0.0. Release notes *Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://github.com/actions/setup-java/pull/888) > > Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Dependency Upgrades > > * Upgrade Publish Immutable Action by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://github.com/actions/setup-java/pull/798) > * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://github.com/actions/setup-java/pull/730) > * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://github.com/actions/setup-java/pull/833) > * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://github.com/actions/setup-java/pull/887) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://github.com/actions/setup-java/pull/896) > > ### Bug Fixes > > * Prevent default installation of JetBrains pre-releases by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://github.com/actions/setup-java/pull/859) > * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://github.com/actions/setup-java/pull/848) > > New Contributors > ---------------- > > * [`@gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://github.com/actions/setup-java/pull/848) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://github.com/actions/setup-java/pull/888) > > **Full Changelog**: <actions/setup-java@v4...v5.0.0> > > v4.7.1 > ------ > > What's Changed > -------------- > > ### Documentation changes > > * Add Documentation to Recommend Using GraalVM JDK 17 Version to 17.0.12 to Align with GFTC License Terms by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-java#704](https://github.com/actions/setup-java/pull/704) > * Remove duplicated GraalVM section in documentation by [`@Marcono1234`](https://github.com/Marcono1234) in [actions/setup-java#716](https://github.com/actions/setup-java/pull/716) > > ### Dependency updates: > > * Upgrade `@action/cache` from 4.0.0 to 4.0.2 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-java#766](https://github.com/actions/setup-java/pull/766) > * Upgrade `@actions/glob` from 0.4.0 to 0.5.0 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#744](https://github.com/actions/setup-java/pull/744) > * Upgrade ts-jest from 29.1.2 to 29.2.5 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#743](https://github.com/actions/setup-java/pull/743) > * Upgrade `@action/cache` to 4.0.3 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-java#773](https://github.com/actions/setup-java/pull/773) > > **Full Changelog**: <actions/setup-java@v4...v4.7.1> > > v4.7.0 > ------ > > What's Changed > -------------- > > * Configure Dependabot settings by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#722](https://github.com/actions/setup-java/pull/722) > * README Update: Added a permissions section by [`@benwells`](https://github.com/benwells) in [actions/setup-java#723](https://github.com/actions/setup-java/pull/723) > * Upgrade `cache` from version 3.2.4 to 4.0.0 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-java#724](https://github.com/actions/setup-java/pull/724) > * Upgrade `@actions/http-client` from 2.2.1 to 2.2.3 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#728](https://github.com/actions/setup-java/pull/728) > * Upgrade `actions/publish-immutable-action` from 0.0.3 to 0.0.4 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#727](https://github.com/actions/setup-java/pull/727) > * Upgrade `@types/jest` from 29.5.12 to 29.5.14 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#729](https://github.com/actions/setup-java/pull/729) ... (truncated) Commits * [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://github.com/actions/setup-java/issues/896)) * [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://github.com/actions/setup-java/issues/888)) * [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://github.com/actions/setup-java/issues/887)) * [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://github.com/actions/setup-java/issues/833)) * [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://github.com/actions/setup-java/issues/730)) * [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://github.com/actions/setup-java/issues/859)) * [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu... * [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://github.com/actions/setup-java/issues/798)) * [`c5195ef`](actions/setup-java@c5195ef) actions/cache upgrade to 4.0.3 ([#773](https://github.com/actions/setup-java/issues/773)) * [`dd38875`](actions/setup-java@dd38875) Bump ts-jest from 29.1.2 to 29.2.5 ([#743](https://github.com/actions/setup-java/issues/743)) * Additional commits viewable in [compare view](actions/setup-java@v4.6.0...dded088) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Description:
This PR will update to recommend using graalvm 17 version to comply with the GraalVM free terms and conditions license(GFTC).