Create ADR for integrating cache functionality to setup-go action #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brcrista
reviewed
Apr 13, 2022
| with: | ||
| go-version: '18' | ||
| cache: true | ||
| cache-dependency-path: **/go.sum |
There was a problem hiding this comment.
What happens if you set cache-dependency-path without setting cache? Does it imply cache? I suppose there's precedent here from the other setup- actions, but just wanted to clarify here
There was a problem hiding this comment.
The cache-dependency-path input only works with enabled cache. The cache-dependency-path will override file from which cache is generated.
IvanZosimov
approved these changes
Apr 14, 2022
|
for reference, see #130 |
marko-zivic-93
approved these changes
Apr 15, 2022
vsafonkin
approved these changes
Apr 15, 2022
brcrista
approved these changes
Apr 15, 2022
vsafonkin
approved these changes
Apr 21, 2022
panticmilos
pushed a commit
to panticmilos/setup-go
that referenced
this pull request
Aug 4, 2022
n33pm
pushed a commit
to n33pm/setup-go
that referenced
this pull request
Oct 17, 2022
adilhusain-s
pushed a commit
to adilhusain-s/setup-go
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare an ADR for support caching in setup-go.