Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) update dependencies #144

Closed
wants to merge 2 commits into from
Closed

chore(ci) update dependencies #144

wants to merge 2 commits into from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Aug 23, 2021

Hi ! Based on setup-node, this PR allows to cache GOCACHE (go-build directory), and GOMODCACHE( ~/go/pkg/mod) folders. I have also updated the dependencies. It follows this example.
This fixes #130

@mmorel-35 mmorel-35 requested a review from a team August 23, 2021 12:32
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@mmorel-35
Copy link
Author

Hi @bryanmacfarlane and @joshmgross, when you find the time, would you like to take a look?

@mmorel-35 mmorel-35 marked this pull request as draft August 25, 2021 16:39
@mmorel-35 mmorel-35 marked this pull request as ready for review August 25, 2021 22:12
Copy link
Member

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey @mmorel-35,

Could we separate this PR into updating the dependencies and adding a new feature? It's difficult to review both, and I'd rather we focus on each individually in separate pull requests.

@mmorel-35
Copy link
Author

Alright, I'll start with the cache feature then

@mmorel-35 mmorel-35 marked this pull request as draft August 26, 2021 17:56
mmorel-35 and others added 2 commits August 26, 2021 22:08
Signed-off-by: Matthieu MOREL <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mmorel-35 mmorel-35 changed the title chore(ci) update dependencies and cache capability chore(ci) update dependencies Aug 26, 2021
@mmorel-35
Copy link
Author

mmorel-35 commented Aug 26, 2021

I didn't thought I would be such a mess. I tried to stick to the cache but It keeps failing... I can't see what's the cause of this https://github.com/mmorel-35/setup-go/runs/3436900337?check_suite_focus=true . Any Idea.

I'm quite disapointed the build was passing before I tried to split things up... I understand that's not easy to review many modifications. But I'm gonna need some help on this.

@mmorel-35 mmorel-35 closed this Aug 27, 2021
@joshmgross
Copy link
Member

👋 @mmorel-35 I don't have access to view that run failure, what was failing?

@mmorel-35
Copy link
Author

This was caused by actions/core upgrade to 1.5.0 which doesn't produces the same logs when Go is added to the $PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support built-in cache
2 participants