-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci) update dependencies #144
Conversation
Hi @bryanmacfarlane and @joshmgross, when you find the time, would you like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey @mmorel-35,
Could we separate this PR into updating the dependencies and adding a new feature? It's difficult to review both, and I'd rather we focus on each individually in separate pull requests.
Alright, I'll start with the cache feature then |
Signed-off-by: Matthieu MOREL <[email protected]> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I didn't thought I would be such a mess. I tried to stick to the cache but It keeps failing... I can't see what's the cause of this https://github.com/mmorel-35/setup-go/runs/3436900337?check_suite_focus=true . Any Idea. I'm quite disapointed the build was passing before I tried to split things up... I understand that's not easy to review many modifications. But I'm gonna need some help on this. |
👋 @mmorel-35 I don't have access to view that run failure, what was failing? |
This was caused by actions/core upgrade to 1.5.0 which doesn't produces the same logs when Go is added to the $PATH. |
Hi ! Based on setup-node, this PR allows to cache GOCACHE (go-build directory), and GOMODCACHE( ~/go/pkg/mod) folders. I have also updated the dependencies. It follows this example.
This fixes #130