Unlock Node.js 18 & 20 #2643
Closed
Unlock Node.js 18 & 20 #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
commented
Jun 3, 2023
|
We are now fully ready to go ahead! |
|
This needs to happen since nodes 16 is going to be EOL in September. |
|
@domenkozar I have to agree with that, but the Actions team seems less willing to accept such a change 😮💨 |
|
Thank you for your changes @smorimoto -- it's awesome! We will probably take this patch home in nixpkgs for our packages. |
|
JFYI, @smorimoto latest runner release (2.308.0) contains latest node16 version and node20 version |
|
@takost Fantastic! I made this PR mainly for actions/checkout#334, does that mean it will be fixed in the future? (Or has it already been fixed?) |
Obagoal1
approved these changes
Aug 22, 2023
| acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-arm64.tar.gz" node16 fix_nested_dir | ||
| acquireExternalTool "$NODE_URL/v${NODE18_VERSION}/node-v${NODE18_VERSION}-darwin-arm64.tar.gz" node18 fix_nested_dir | ||
| acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-arm64.tar.gz" node20 fix_nested_dir | ||
| fi | ||
|
|
||
| # Download the external tools for Linux PACKAGERUNTIMEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we will unlock Node.js 18 and 20, but there are two key points here.
The first is that, until now, we've been using a special build from the Node.js team for ARM Windows, but starting from 20, builds for ARM exist by default. So if you don't bump the 16 version, we have to make a special arm build just for 18, which is already out of support. I've asked the Node.js team to help us by providing special builds.
Second, the build for Alpine used to provide a special build from the actions team via blob storage, but that can be resolved using the musl build from the Node.js team.
You're starting to see a point to discuss here, as well. That is, how do you go about Node.js 18? I don't see any good reason to include it. The build for ARM Windows is missing, and 16 and 20 are enough. Doing so can reduce both the scripts and the work in the unofficial build repository. This makes a lot of sense.