-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend github context with host-workspace #2517
Merged
nikola-jokic
merged 9 commits into
actions:main
from
nikola-jokic:nikola-jokic/host-workspace-ctx
Jun 29, 2023
Merged
Extend github context with host-workspace #2517
nikola-jokic
merged 9 commits into
actions:main
from
nikola-jokic:nikola-jokic/host-workspace-ctx
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
@nikola-jokic could you please help us to fix this issue we are stuck from last week on same stage, I dont have resolution for this. |
nikola-jokic
force-pushed
the
nikola-jokic/host-workspace-ctx
branch
from
June 27, 2023 08:50
88a37b1
to
9a03f27
Compare
fhammerl
reviewed
Jun 28, 2023
fhammerl
reviewed
Jun 28, 2023
Co-authored-by: fhammerl <[email protected]>
nikola-jokic
changed the title
Extend runner context with host-workspace
Extend runner context with host-work-directory
Jun 28, 2023
nikola-jokic
changed the title
Extend runner context with host-work-directory
Extend github context with host-workspace
Jun 29, 2023
fhammerl
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ashb
pushed a commit
to ashb/runner
that referenced
this pull request
Jun 30, 2023
* hash files translation works with host context translated * Change file encoding to utf8 for PipelineTemplateConstants.cs * infer the feature flag on hash files based on the existence of the context * encoded utf8 with bom * rename host-workspace to host-work-directory and feature flag the new context var * Added comment to explain ignore host work directory resolution Co-authored-by: fhammerl <[email protected]> * trigger pipeline * Move to the github host-workspace context instead of the runner host-work-directory * remove unused imports --------- Co-authored-by: fhammerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue where step host was not used when evaluating user inputs.
The PR #1762 fixed this problem, but it introduced another problem for hash files.
hashFiles operates on the host, regardless of whether you are running inside the container or not.
Since inputs are translated based on the step host, we lose the ability to know how to translate back from the container path to the host path.
This change aims to add another context variable to the runner context named
host-workspace
that will be set to the runner host workspace regardless of whether the action is executed inside the container or not.Example of the composite action:
Repro of this issue with StepHost evaluation and hash files:
After applying this change:
Related to #716