Skip to content

Add ADR for Container Hooks#1891

Merged
thboop merged 9 commits into
mainfrom
thboop/ContainerHookADR
Jun 10, 2022
Merged

Add ADR for Container Hooks#1891
thboop merged 9 commits into
mainfrom
thboop/ContainerHookADR

Conversation

@thboop

@thboop thboop commented May 12, 2022

Copy link
Copy Markdown
Collaborator

This ADR details expanding the Job Hook concept to create container hooks that you can use to invoke containers in your preferred way.

Rendered

@thboop thboop requested a review from a team as a code owner May 12, 2022 20:03
@ruvceskistefan

Copy link
Copy Markdown
Contributor

Maybe we should add one sentence about location of response file (_temp/_hook_responses) in the section Writing responses to a file

Comment thread docs/adrs/1891-container-hooks.md
Comment thread docs/adrs/1891-container-hooks.md Outdated
Comment thread docs/adrs/1891-container-hooks.md Outdated
Comment thread docs/adrs/1891-container-hooks.md Outdated
Comment thread docs/adrs/1891-container-hooks.md Outdated
Comment thread docs/adrs/1891-container-hooks.md Outdated
Comment thread docs/adrs/1891-container-hooks.md Outdated
thboop and others added 6 commits June 10, 2022 09:30
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>

@fhammerl fhammerl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit 0d1e6fd into main Jun 10, 2022
@thboop thboop deleted the thboop/ContainerHookADR branch June 10, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants