Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner config option to disable auto-update. #1558

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Runner config option to disable auto-update. #1558

merged 6 commits into from
Jan 26, 2022

Conversation

TingluoHuang
Copy link
Member

https://github.com/github/c2c-actions-runtime/issues/1559

Add --disableupdate runner config option to allow the runner to opt-out auto-update to the latest version.

@ethomson
Copy link
Contributor

Thanks for opening this @TingluoHuang! For anybody following along at home, I wanted to point out that this is a necessary change to disable self updates but not sufficient. As I mentioned in #1396, this will require changes in both the runner and the service. These are only the runner pieces, and so if you were to (for example) build a version of the runner with this PR, we will not queue jobs to your runner when you are out of date.

I just wanted to set expectations for anybody perusing the PRs in this repository. 😁

@TingluoHuang TingluoHuang force-pushed the users/tihuang/disableupdate branch from 7a61382 to c2e132a Compare January 18, 2022 19:38
@TingluoHuang TingluoHuang force-pushed the users/tihuang/disableupdate branch from c2e132a to 0aa1c0f Compare January 18, 2022 19:48
@TingluoHuang TingluoHuang marked this pull request as ready for review January 18, 2022 20:20
@TingluoHuang TingluoHuang requested a review from a team as a code owner January 18, 2022 20:20
thboop
thboop previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor nits

thboop
thboop approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TingluoHuang TingluoHuang merged commit 8eacbdc into main Jan 26, 2022
@TingluoHuang TingluoHuang deleted the users/tihuang/disableupdate branch January 26, 2022 18:23
@kuju63 kuju63 mentioned this pull request Jan 28, 2022
Closed
fhammerl added a commit that referenced this pull request Feb 2, 2022
@fhammerl
Squashed commit of the following:
0605c35 
commit edfb51a
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 11:01:15 2022 +0000

    Better comments

commit 94aa16b
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:56:21 2022 +0000

    Only in debug

commit e2f4c6c
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:53:46 2022 +0000

    Formatting

commit c13ebc3
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:50:44 2022 +0000

    Formatting

commit 70f8576
Merge: 8d3ae51 8f160bc
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:44:25 2022 +0000

    Merge branch 'main' of https://github.com/actions/runner into fhammerl/mock-update

commit 8d3ae51
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:40:59 2022 +0000

    Remove test changes

commit 4c5e005
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 10:39:04 2022 +0000

    Update test version-map, remove hardcoded 'true'

commit 8f160bc
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Feb 2 11:16:01 2022 +0100

    Reopen 'Make run.sh|cmd handle update without quitting so containers using them as entrypoints don't exit on update ' (#1646)

    * Only execute post for actions that have one

    * Working container runner update with run.sh

    * Revert "Only execute post for actions that have one"

    This reverts commit 9675941.

    * Relaunch the listener without quitting run.cmd

    * Fix typo

    * Extract most os run.sh logic so we can update it

    * Add bash line endings

    * Extract the logic from run.cmd

    * Add EoF lines

    * Add unexpected ERRORLEVEL messages to cmd

    * Simplify contract between run and helper

    * Remove unused exit

    * WIP: run a copy of the helper so it's safe to update

    * Throw NonRetryableException if not configured

    * Log and format

    * Fix typo

    * Fix typo

    * Use helper template system for bash as well

    * Update run.sh

    * Remove unnecessary comments

    * Use ping instead of timeout

    * Use localhost in ping-timeout (n times, w timeout)

    Co-authored-by: Ferenc Hammerl <[email protected]>

commit 47ba120
Author: Thomas Boop <[email protected]>
Date:   Tue Feb 1 09:19:04 2022 -0500

    Revert "Make `run.sh|cmd` handle update without quitting so container… (#1635)

    * Revert "Make `run.sh|cmd` handle update without quitting so containers using them as entrypoints don't exit on update (#1494)"

    d8251bf

    * update runnerversion as well

commit dc8b1b6
Author: Thomas Boop <[email protected]>
Date:   Thu Jan 27 11:28:40 2022 -0500

    Runner 2.287.0 Release Notes (#1631)

    * Update runner to 2.287.0

    * Update release notes

commit 8eacbdc
Author: Tingluo Huang <[email protected]>
Date:   Wed Jan 26 13:23:24 2022 -0500

    Runner config option to disable auto-update. (#1558)

    * Runner config option to disable auto-update.

    * Update src/Runner.Listener/Configuration/ConfigurationManager.cs

    Co-authored-by: Thomas Boop <[email protected]>

    * Update src/Runner.Listener/Configuration/ConfigurationManager.cs

    Co-authored-by: Thomas Boop <[email protected]>

    * Update src/Runner.Listener/Configuration/ConfigurationManager.cs

    Co-authored-by: Thomas Boop <[email protected]>

    * Update src/Runner.Listener/Configuration/ConfigurationManager.cs

    Co-authored-by: Thomas Boop <[email protected]>

    * feedback.

    Co-authored-by: Thomas Boop <[email protected]>

commit 689035e
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 26 14:32:30 2022 +0000

    Use KV map to mock update

commit 6b4a95c
Author: Pavel Iakovenko <[email protected]>
Date:   Mon Jan 24 13:57:05 2022 -0500

    Use default 8Mb chunking for the FileContainer uploads (#1626)

commit c95d5ea
Author: Josh Soref <[email protected]>
Date:   Fri Jan 21 11:35:50 2022 -0500

    Update 0276-problem-matchers.md (#1105)

    * Update 0276-problem-matchers.md

    Update to reflect current behavior

    * Update docs/adrs/0276-problem-matchers.md

    Co-authored-by: Ferenc Hammerl <[email protected]>

commit ea67ff9
Author: Rob Cowsill <[email protected]>
Date:   Fri Jan 21 16:35:29 2022 +0000

    Update Required Dev Dependencies (#1379)

    * Add cURL to Linux requirements

    * Add VS2017 to Windows requirements

commit d7d38e1
Author: Josh Soref <[email protected]>
Date:   Fri Jan 21 11:35:14 2022 -0500

    Update 0354-runner-machine-info.md (#1108)

commit ac31fd1
Author: Tingluo Huang <[email protected]>
Date:   Wed Jan 19 10:31:17 2022 -0500

    Introduce GITHUB_ACTIONS_RUNNER_TLS_NO_VERIFY=1 to skip SSL cert verification for the runner. (#1616)

commit d8251bf
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 19 14:38:43 2022 +0100

    Make `run.sh|cmd` handle update without quitting so containers using them as entrypoints don't exit on update (#1494)

    * Only execute post for actions that have one

    * Working container runner update with run.sh

    * Revert "Only execute post for actions that have one"

    This reverts commit 9675941.

    * Relaunch the listener without quitting run.cmd

    * Fix typo

    * Extract most os run.sh logic so we can update it

    * Add bash line endings

    * Extract the logic from run.cmd

    * Add EoF lines

    * Add unexpected ERRORLEVEL messages to cmd

    * Simplify contract between run and helper

    * Remove unused exit

    * WIP: run a copy of the helper so it's safe to update

    * Throw NonRetryableException if not configured

    * Log and format

    * Fix typo

    * Fix typo

    * Use helper template system for bash as well

    * Update run.sh

    * Remove unnecessary comments

    * Use ping instead of timeout

    * Use localhost in ping-timeout (n times, w timeout)

    Co-authored-by: Ferenc Hammerl <[email protected]>

commit d8351e3
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 19 10:27:36 2022 +0000

    Use local ping

commit 1406602
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 22:55:56 2022 +0000

    Ping instead of timeout

commit 66cce79
Merge: 4768372 1bf42ba
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 13:24:16 2022 +0000

    Merge branch 'fhammerl/run-sh-handle-update-containers' of https://github.com/actions/runner into fhammerl/mock-update

commit 4768372
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 12:07:45 2022 +0000

    Use old method

commit bc9b076
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 12:01:51 2022 +0000

    Mock message not files

commit 0f470c6
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 10:37:15 2022 +0100

    More logging

commit 8367d76
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Jan 18 10:26:50 2022 +0100

    Add update logging

commit 1bf42ba
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Jan 13 15:26:29 2022 +0100

    Update run.sh

commit 68e45d7
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Jan 13 14:28:28 2022 +0100

    Make wait for debugger optional

commit 38332e1
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Jan 13 13:42:33 2022 +0100

    Use files not env

commit 161666a
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 12 20:58:45 2022 +0100

    Remove if debug

commit 2116e71
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 12 20:41:50 2022 +0100

    Remove if debug add logs

commit d938bdf
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 12 20:35:57 2022 +0100

    Add debugger and logging to self update

commit c353760
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 12 17:45:48 2022 +0100

    Add mock logging

commit df18086
Merge: 5c72801 3b8475d
Author: Ferenc Hammerl <[email protected]>
Date:   Mon Jan 10 11:55:25 2022 +0100

    Merge branch 'main' of github.com:actions/runner into fhammerl/mock-update

commit 5c72801
Merge: beaa6fe f2e210e
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Jan 7 17:33:03 2022 +0100

    Merge branch 'main' of github.com:actions/runner into fhammerl/mock-update

commit beaa6fe
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 5 14:29:43 2022 +0100

    Add note about how to trigger runner updates

commit 6ed5d6c
Merge: b5c5b5c 46da23e
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 5 14:22:35 2022 +0100

    Merge branch 'main' of github.com:actions/runner into fhammerl/mock-update

commit b5c5b5c
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 5 14:22:11 2022 +0100

    Suffix with correct archive format

commit 6fabd82
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Jan 5 14:14:45 2022 +0100

    Allow mocked updates

commit 9a7a674
Author: Ferenc Hammerl <[email protected]>
Date:   Mon Jan 3 09:54:41 2022 +0100

    Use helper template system for bash as well

commit 7e7c4c1
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Dec 15 16:35:58 2021 +0100

    Fix typo

commit 7251905
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Dec 14 16:47:53 2021 +0100

    Fix typo

commit 2a4e99f
Author: Ferenc Hammerl <[email protected]>
Date:   Mon Dec 13 11:53:20 2021 +0100

    Log and format

commit b2598a6
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 10 14:41:27 2021 +0100

    Throw NonRetryableException if not configured

commit 7574efa
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 10 13:58:27 2021 +0100

    WIP: run a copy of the helper so it's safe to update

commit 24f70b7
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 10 13:51:43 2021 +0100

    Remove unused exit

commit ada666b
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 10 11:10:26 2021 +0100

    Simplify contract between run and helper

commit e62aa73
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 10 10:15:27 2021 +0100

    Add unexpected ERRORLEVEL messages to cmd

commit 9839a76
Merge: 8660d05 dde7130
Author: Ferenc Hammerl <[email protected]>
Date:   Wed Dec 8 15:20:57 2021 +0100

    Merge branch 'fhammerl/run-sh-handle-update-containers' of github.com:actions/runner into fhammerl/run-sh-handle-update-containers

commit dde7130
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Dec 3 19:23:02 2021 +0100

    Add EoF lines

commit 493abce
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Dec 2 16:02:41 2021 +0100

    Extract the logic from run.cmd

commit 8660d05
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Dec 2 15:21:19 2021 +0100

    Add bash line endings

commit 66dde76
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Dec 2 15:10:42 2021 +0100

    Extract most os run.sh logic so we can update it

commit edb6483
Author: Ferenc Hammerl <[email protected]>
Date:   Tue Nov 30 15:40:02 2021 +0100

    Fix typo

commit c850c8c
Author: Ferenc Hammerl <[email protected]>
Date:   Mon Nov 29 15:12:59 2021 +0100

    Relaunch the listener without quitting run.cmd

commit 7d34d02
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Nov 18 18:12:42 2021 +0100

    Revert "Only execute post for actions that have one"

    This reverts commit 9675941.

commit 87054ff
Author: Ferenc Hammerl <[email protected]>
Date:   Thu Nov 18 15:54:27 2021 +0100

    Working container runner update with run.sh

commit 9675941
Author: Ferenc Hammerl <[email protected]>
Date:   Fri Nov 12 13:31:37 2021 +0100

    Only execute post for actions that have one
@t0rr3sp3dr0 t0rr3sp3dr0 mentioned this pull request Mar 3, 2022
Merged
@ldaneliukas ldaneliukas mentioned this pull request Jun 1, 2022
Merged
@myoung34 myoung34 mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson left review comments

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TingluoHuang @ethomson @thboop