Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where nested local composite actions did not correctly register post steps #1433

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Oct 26, 2021

This pr fixes an issue where a local composite action inside another local composite action would not run any post steps for individual steps in that action.

Resolves #1434

@thboop thboop requested a review from a team as a code owner October 26, 2021 13:07
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhammerl fhammerl merged commit 854d5e3 into main Oct 27, 2021
@fhammerl fhammerl deleted the fhammerl/fix-nested-pre-post branch October 27, 2021 13:32
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Nov 16, 2022
…egister post steps (actions#1433)

* Always register post steps for local actions

* Register post steps along with their conditions

* remove debug code

Co-authored-by: Ferenc Hammerl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Composite Actions do not run post jobs
2 participants