only cleanup runner local files on success #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hross
approved these changes
Sep 28, 2021
TingluoHuang
approved these changes
Sep 28, 2021
pje
approved these changes
Sep 28, 2021
fhammerl
added a commit
that referenced
this pull request
Sep 30, 2021
* Update telemetry (#1355) * Track "pause-logging" * Bump release version * Don't retry 422 (#1352) * Update the comment about the `--once` in Constants.cs (#1360) * Update Constants.cs * feedback. * Update src/Runner.Listener/Runner.cs Co-authored-by: Thomas Boop <[email protected]> Co-authored-by: Thomas Boop <[email protected]> * Fix unconfiguring of runner after group changes (#1359) * Ignore agentpool when unconfiguring the runner Runner names and IDs are unique within a ServiceHost They don't need to be included when unconfiguring the runner. * Use -1 instead of 0 to highlight how it is ignored * Use overloads and 0 instead of -1 Using 0 seems to be the convention * Fix typo calling the wrong method * only cleanup runner local files on success (#1384) * Stop-Commands: stopToken restrictions (#1371) * Prevent stopTokens that are workflow commands Co-authored-by: Thomas Boop <[email protected]> * Check context for env var too * Accept true, 1 and $true instead of just "true" * Setup ExpressionValues in tests * Update src/Runner.Common/Constants.cs Co-authored-by: Thomas Boop <[email protected]> * Separate success and fail tests for invalid token * Fix envcontext for tests Co-authored-by: Thomas Boop <[email protected]> * Handle keeping previous OSX versions more smoothly on Mac (#1381) * Handle macOS upgrade smoothly * cleanup * misc cleanup * final updates * Update src/Misc/layoutbin/update.sh.template Co-authored-by: Patrick Ellis <[email protected]> * Update src/Misc/layoutbin/update.sh.template Co-authored-by: Patrick Ellis <[email protected]> * Upload telemetry and default to old method as needed * minor fix * add one more bit of logging * some more telemetry * quote variables to handle spaces * tiny fix for ubuntu * remove version and move telemetry to diag * use full path Co-authored-by: Patrick Ellis <[email protected]> * Runner 2.283.2 Release (#1389) Co-authored-by: Thomas Boop <[email protected]> Co-authored-by: Tingluo Huang <[email protected]> Co-authored-by: Patrick Ellis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated the happy path deletes the runner, and manually canceling runner execution leaves the file so a user can later clean those up.
Resolves #1370