Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] split docker install into 3 scripts #8688

Merged
merged 5 commits into from
Nov 6, 2023
Merged

[windows] split docker install into 3 scripts #8688

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d30590
[windows] split docker install into 3 scripts
ilia-shipitsin Oct 30, 2023
42fcc06
Update images/win/scripts/Installers/Install-Docker-Compose.ps1
ilia-shipitsin Oct 31, 2023
65c8d7a
Update images/win/scripts/Installers/Install-Docker-WinCred.ps1
ilia-shipitsin Oct 31, 2023
ef381a3
fix test
ilia-shipitsin Nov 2, 2023
85bc55f
Merge branch 'feat_split_docker_install' of github.com:ilia-shipitsin…
ilia-shipitsin Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions images/win/scripts/Installers/Install-Docker-Compose.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
################################################################################
## File: Install-Docker-Compose.ps1
## Desc: Install Docker Compose.
ilia-shipitsin marked this conversation as resolved.
Show resolved Hide resolved
## Supply chain security: Docker Compose v1 - by package manager
################################################################################

Write-Host "Install-Package Docker-Compose v1"
$versionToInstall = Get-LatestChocoPackageVersion -TargetVersion "1.29" -PackageName "docker-compose"
Choco-Install -PackageName docker-compose -ArgumentList "--version=$versionToInstall"

Write-Host "Install-Package Docker-Compose v2"
$dockerComposev2Url = "https://github.com/docker/compose/releases/latest/download/docker-compose-windows-x86_64.exe"
$cliPluginsDir = "C:\ProgramData\docker\cli-plugins"
New-Item -Path $cliPluginsDir -ItemType Directory
Start-DownloadWithRetry -Url $dockerComposev2Url -Name docker-compose.exe -DownloadPath $cliPluginsDir

Invoke-PesterTests -TestFile "Docker" -TestName "DockerCompose"
37 changes: 37 additions & 0 deletions images/win/scripts/Installers/Install-Docker-WinCred.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
################################################################################
## File: Install-Docker-WinCred.ps1
## Desc: Install Docker credential helper.
## Supply chain security: checksum validation
################################################################################

#region functions
Function Get-DockerWincredHash
{
Param (
[Parameter(Mandatory = $True)]
[string] $Release
)

$hashURL = "https://github.com/docker/docker-credential-helpers/releases/download/${Release}/checksums.txt "
(Invoke-RestMethod -Uri $hashURL).ToString().Split("`n").Where({ $_ -ilike "*docker-credential-wincred-${Release}.windows-amd64.exe*" }).Split(' ')[0]

}
ilia-shipitsin marked this conversation as resolved.
Show resolved Hide resolved
#endregion

Write-Host "Install docker-wincred"
$dockerCredLatestRelease = Invoke-RestMethod -Uri "https://api.github.com/repos/docker/docker-credential-helpers/releases/latest"
$dockerCredDownloadUrl = $dockerCredLatestRelease.assets.browser_download_url -match "docker-credential-wincred-.+\.exe" | Select-Object -First 1
Start-DownloadWithRetry -Url $dockerCredDownloadUrl -DownloadPath "C:\Windows\System32" -Name "docker-credential-wincred.exe"

#region Supply chain security
$distributor_file_hash = Get-DockerWincredHash -Release $dockerCredLatestRelease.name
$local_file_hash = (Get-FileHash -Path 'C:\Windows\System32\docker-credential-wincred.exe' -Algorithm SHA256).Hash

if ($local_file_hash -ne $distributor_file_hash) {
Write-Host "hash must be equal to: ${distributor_file_hash}"
Write-Host "actual hash is: ${local_file_hash}"
throw 'Checksum verification failed, please rerun install'
}
#endregion

Invoke-PesterTests -TestFile "Docker" -TestName "DockerWinCred"
44 changes: 2 additions & 42 deletions images/win/scripts/Installers/Install-Docker.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,8 @@
## Desc: Install Docker.
## Must be an independent step because it requires a restart before we
## can continue.
## Supply chain security: (docker-wincred) checksum validation
################################################################################

#region functions
Function Get-DockerWincredHash
{
Param (
[Parameter(Mandatory = $True)]
[string] $Release
)

$hashURL = "https://github.com/docker/docker-credential-helpers/releases/download/${Release}/checksums.txt "
(Invoke-RestMethod -Uri $hashURL).ToString().Split("`n").Where({ $_ -ilike "*docker-credential-wincred-${Release}.windows-amd64.exe*" }).Split(' ')[0]

}
#endregion

Write-Host "Get latest Moby release"
$mobyLatestReleaseVersion = (Invoke-RestMethod -Uri "https://api.github.com/repos/moby/moby/releases/latest").tag_name.Trim("v")
$dockerceUrl = "https://download.docker.com/win/static/stable/x86_64/"
Expand Down Expand Up @@ -55,32 +40,6 @@ if ($LastExitCode -ne 0) {
# https://github.com/Azure/azure-cli/issues/18766
New-Item -ItemType SymbolicLink -Path "C:\Windows\SysWOW64\docker.exe" -Target "C:\Windows\System32\docker.exe"

Write-Host "Install-Package Docker-Compose v1"
$versionToInstall = Get-LatestChocoPackageVersion -TargetVersion "1.29" -PackageName "docker-compose"
Choco-Install -PackageName docker-compose -ArgumentList "--version=$versionToInstall"

Write-Host "Install-Package Docker-Compose v2"
$dockerComposev2Url = "https://github.com/docker/compose/releases/latest/download/docker-compose-windows-x86_64.exe"
$cliPluginsDir = "C:\ProgramData\docker\cli-plugins"
New-Item -Path $cliPluginsDir -ItemType Directory
Start-DownloadWithRetry -Url $dockerComposev2Url -Name docker-compose.exe -DownloadPath $cliPluginsDir

Write-Host "Install docker-wincred"
$dockerCredLatestRelease = Invoke-RestMethod -Uri "https://api.github.com/repos/docker/docker-credential-helpers/releases/latest"
$dockerCredDownloadUrl = $dockerCredLatestRelease.assets.browser_download_url -match "docker-credential-wincred-.+\.exe" | Select-Object -First 1
Start-DownloadWithRetry -Url $dockerCredDownloadUrl -DownloadPath "C:\Windows\System32" -Name "docker-credential-wincred.exe"

#region Supply chain security
$distributor_file_hash = Get-DockerWincredHash -Release $dockerCredLatestRelease.name
$local_file_hash = (Get-FileHash -Path 'C:\Windows\System32\docker-credential-wincred.exe' -Algorithm SHA256).Hash

if ($local_file_hash -ne $distributor_file_hash) {
Write-Host "hash must be equal to: ${distributor_file_hash}"
Write-Host "actual hash is: ${local_file_hash}"
throw 'Checksum verification failed, please rerun install'
}
#endregion

Write-Host "Download docker images"
$dockerImages = (Get-ToolsetContent).docker.images
foreach ($dockerImage in $dockerImages) {
Expand All @@ -93,4 +52,5 @@ foreach ($dockerImage in $dockerImages) {
}
}

Invoke-PesterTests -TestFile "Docker"
Invoke-PesterTests -TestFile "Docker" -TestName "Docker"
Invoke-PesterTests -TestFile "Docker" -TestName "DockerImages"
26 changes: 18 additions & 8 deletions images/win/scripts/Tests/Docker.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,35 @@
Describe "Docker" {
It "<ToolName>" -TestCases @(
@{ ToolName = "docker" }
@{ ToolName = "docker-compose" }
) {
"$ToolName --version" | Should -ReturnZeroExitCode
}
ilia-shipitsin marked this conversation as resolved.
Show resolved Hide resolved

It "docker-wincred" {
"docker-credential-wincred version" | Should -ReturnZeroExitCode
It "docker service is up" {
"docker images" | Should -ReturnZeroExitCode
}

It "docker symlink" {
"C:\Windows\SysWOW64\docker.exe ps" | Should -ReturnZeroExitCode
}
}

Describe "DockerCompose" {
It "<ToolName>" -TestCases @(
@{ ToolName = "docker-compose" }
) {
"$ToolName --version" | Should -ReturnZeroExitCode
}
ilia-shipitsin marked this conversation as resolved.
Show resolved Hide resolved

It "docker compose v2" {
"docker compose version" | Should -ReturnZeroExitCode
}

It "docker service is up" {
"docker images" | Should -ReturnZeroExitCode
}
}

It "docker symlink" {
"C:\Windows\SysWOW64\docker.exe ps" | Should -ReturnZeroExitCode
Describe "DockerWinCred" {
It "docker-wincred" {
"docker-credential-wincred version" | Should -ReturnZeroExitCode
}
}

Expand Down
2 changes: 2 additions & 0 deletions images/win/windows2019.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@
"scripts": [
"{{ template_dir }}/scripts/Installers/Install-VCRedist.ps1",
"{{ template_dir }}/scripts/Installers/Install-Docker.ps1",
"{{ template_dir }}/scripts/Installers/Install-Docker-WinCred.ps1",
"{{ template_dir }}/scripts/Installers/Install-Docker-Compose.ps1",
"{{ template_dir }}/scripts/Installers/Install-PowershellCore.ps1",
"{{ template_dir }}/scripts/Installers/Install-WebPlatformInstaller.ps1"
]
Expand Down
2 changes: 2 additions & 0 deletions images/win/windows2022.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@
"type": "powershell",
"scripts": [
"{{ template_dir }}/scripts/Installers/Install-Docker.ps1",
"{{ template_dir }}/scripts/Installers/Install-Docker-WinCred.ps1",
"{{ template_dir }}/scripts/Installers/Install-Docker-Compose.ps1",
"{{ template_dir }}/scripts/Installers/Install-PowershellCore.ps1",
"{{ template_dir }}/scripts/Installers/Install-WebPlatformInstaller.ps1"
]
Expand Down