Skip to content

Install MSYS2 to Windows.#585

Merged
AlenaSviridenko merged 29 commits intoactions:masterfrom
vsafonkin:v-vlsafo/msys2-install
Mar 26, 2020
Merged

Install MSYS2 to Windows.#585
AlenaSviridenko merged 29 commits intoactions:masterfrom
vsafonkin:v-vlsafo/msys2-install

Conversation

@vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented Mar 20, 2020

Issue: #30

Added scripts for installation and validation MSYS2. This PR is based on PR #355 from @MSP-Greg

Installation time: 6 - 7 min
Size: ~4.2 Gb

@maxim-lobanov
Copy link
Contributor

/azp run windows2016, windows2019

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@maxim-lobanov maxim-lobanov mentioned this pull request Mar 24, 2020
5 tasks
@vsafonkin
Copy link
Contributor Author

@MSP-Greg , thanks for your point about embedded msys! We will investigate the possibility of getting rid of it because we're building those Ruby versions on the same windows images so it looks like we need msys2 preinstalled firstly.

@MSP-Greg
Copy link
Contributor

@vsafonkin

Off-topic, kind of Ruby specific

I don't know, as I think the Ruby build/install code is in the super top secret vault area. JFYI, the current script for installing MSYS2 does not contain all the dependencies needed to build Ruby.

I thought keeping it a small as possible was a concern. I also thought that once one starts including packages beyond build tools, it's difficult to decide what should be included. AppVeyor did, and they've got a lot of packages (see https://ci.appveyor.com/project/MSP-Greg/appveyor-ruby).

As to the pre-installed Rubies, they are available in GitHub releases as exe's or 7z files (without devkit/MSYS2); it might be easier to use those. After all, that is what normal users would install...

One thing I did see, below (line 75) is updating RubyGems for the system default Ruby (currently 2.5.x). You might consider doing so for all installed Rubies, or none. To update for just one may be confusing?

https://github.com/actions/virtual-environments/blob/cd130bd7047b24f05cf09002908ed20e852ec087/images/win/scripts/Installers/Download-ToolCache.ps1#L62-L76

@vsafonkin
Copy link
Contributor Author

vsafonkin commented Mar 24, 2020

@MSP-Greg

I don't know, as I think the Ruby build/install code is in the super top secret vault area

we are going to move ruby build/install code to opensource soon.

As to the pre-installed Rubies, they are available in GitHub releases as exe's or 7z files (without devkit/MSYS2); it might be easier to use those. After all, that is what normal users would install...

Could you please clarify what GitHub releases do you mean?

@maxim-lobanov
Copy link
Contributor

/azp run windows2016, windows2019

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Mar 24, 2020

@vsafonkin

Could you please clarify what GitHub releases do you mean?

Sorry. See the releases/tags listed at https://github.com/oneclick/rubyinstaller2/tags. There are multiple files per release, both 64 and 32 bit, and with and without devkit/msys2. For example, the 2.7.0 release without devkit/msys2 is:

https://github.com/oneclick/rubyinstaller2/releases/download/RubyInstaller-2.7.0-1/rubyinstaller-2.7.0-1-x64.7z

Other than the root folder issue, it's everything needed.

EDIT: The custom action ruby/setup-ruby allows installation of virtually any version/platform of Ruby since v2.2.0. It uses the above mentioned builds (https://github.com/oneclick/rubyinstaller2) for its release binaries on Windows.

@vsafonkin
Copy link
Contributor Author

@MSP-Greg , I've got it, thank you!

@maxim-lobanov
Copy link
Contributor

/azp run windows2016, windows2019

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@maxim-lobanov
Copy link
Contributor

/azp run windows2016, windows2019

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants