Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rustup self-updating #10970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions images/macos/scripts/build/install-rust.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ rustup-init -y --no-modify-path --default-toolchain=stable --profile=minimal
echo "Initialize environment variables..."
CARGO_HOME=$HOME/.cargo

echo "Disable rustup self-updating"
# This is undesirable because:
# - We will keep rustup updated (just like any other dependency).
# - rustup does not need to be the latest and greatest.
# - Self-updating in CI will introduce longer build times for no benefit.
# - ... which becomes important because self-updating happens in various
# places, including `rustup toolchain install`.
rustup set auto-self-update disable

echo "Install common tools..."
rustup component add rustfmt clippy

Expand Down
10 changes: 10 additions & 0 deletions images/ubuntu/scripts/build/install-rust.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ curl -fsSL https://sh.rustup.rs | sh -s -- -y --default-toolchain=stable --profi
# Initialize environment variables
source $CARGO_HOME/env

# Disable rustup self-updating
#
# This is undesirable because:
# - We will keep rustup updated (just like any other dependency).
# - Rustup does not need to be the latest and greatest.
# - Self-updating in CI will introduce longer build times for no benefit.
# - ... which becomes important because self-updating happens in various
# places, including `rustup toolchain install`.
rustup set auto-self-update disable

# Install common tools
rustup component add rustfmt clippy

Expand Down
10 changes: 10 additions & 0 deletions images/windows/scripts/build/Install-Rust.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ Add-DefaultPathItem "%USERPROFILE%\.cargo\bin"
# Add Rust binaries to the path
$env:Path += ";$env:CARGO_HOME\bin"

# Disable rustup self-updating
#
# This is undesirable because:
# - We will keep rustup updated (just like any other dependency).
# - rustup does not need to be the latest and greatest.
# - Self-updating in CI will introduce longer build times for no benefit.
# - ... which becomes important because self-updating happens in various
# places, including `rustup toolchain install`.
rustup set auto-self-update disable

# Add i686 target for building 32-bit binaries
rustup target add i686-pc-windows-msvc

Expand Down