You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We decided to get rid of Java12 in the scope of Adopt JDK #883 (comment)
It was proposed to switch default Java version to 11 #883 (comment)
@miketimofeev , @Darleev
We can't do any of them in scope of this PR and this feature since it is a breaking change.
@alepauly is it ok for you if we make the changes outside of this PR?
I don't think that we want to do these changes in near future.
Java size is pretty small and removing Java 12 won't give significant win.
But impact could be pretty huge, especially from switching default version
I don't think that we want to do these changes in near future.
Java size is pretty small and removing Java 12 won't give significant win.
But impact could be pretty huge, especially from switching default version
We can discuss/do it as separate work. The main reason of getting rid of Java 12 is that it sets the expectation that those intermediate versions will be available. I rather have setup-java and useJava deal with that. Once those download on demand we should be able to remove any version (communicating prior that Actions/Task is recommended method).
We'll eventually have to switch to Java 11 as default but I'm not sure the time is right. Perhaps we can see version usage through setup-java/useJava and that will tell us when we should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darleev
requested review from
AlenaSviridenko,
MaksimZhukov,
al-cheb,
andy-mishechkin,
dibir-magomedsaygitov,
dmitry-shibanov,
dsame,
maxim-lobanov,
miketimofeev and
sergey-akhalkov
Description
Improvement
Description: #1057
Related issue:
https://github.com/actions/virtual-environments-internal/issues/685
Check list