-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] C drive is siginificant slower than D drive which causes issue with workflow runtime being significantly increased in general #8755
Comments
Hello @jetersen, |
As far as I understand, this would need a change of |
I don't like the solution to just move everything to the D drive 😅 I would hope the solution was to make C drive have the same iOPS, throughput and disk technology (Premium SSD, Standard SSD, Standard HDD in azure terms) as the D drive |
@jetersen, unfortunately, there is no simple fix to put C drive's performance on par with D drive. |
@shamil-mubarakshin 👋🏻 G'Day. I'm not sure I quite understand the solution here? So changing the "C" drive's hardware isn't going to happen right now / short-term, etc. Fine. .. but surely there's still some possibility of doing some of the actions, running on the "D" drive, right? or even making some approved actions that work on "D" allowing people to "opt-in" to this (for backwards compat)? |
This should hopefully speed up Windows builds on GitHub Actions: actions/runner-images#8755
aren't we using the D drive by default anyway ?
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4
with:
ref: ${{needs.should_run.outputs.output1}}
submodules: recursive |
Summary: Drive C is known to be significantly slower on Github Windows runners: actions/runner-images#8755 Use drive D for Cargo and Rustup. * `build_debug` **hg 23m34s** -> **20m25s** * `build_release` **28m5s** -> **22m56s** Differential Revision: D66011457
Summary: Drive C is known to be significantly slower on Github Windows runners: actions/runner-images#8755 Use drive D for Cargo and Rustup. * `build_debug` **hg 23m34s** -> **20m25s** * `build_release` **28m5s** -> **22m56s** Differential Revision: D66011457
Summary: Drive C is known to be significantly slower on Github Windows runners: actions/runner-images#8755 Use drive D for Cargo and Rustup. * `build_debug` **hg 23m34s** -> **20m25s** * `build_release` **28m5s** -> **22m56s** Differential Revision: D66011457
Description
This seems to affect all Windows based hosted runners.
In general tool installation, download speeds and compression and decompression on anything that is on the C drive as in any IO is significantly slower compared to D drive.
Somewhat based on research in #3577 and actions/setup-dotnet#260
Seems like actions/setup-go seems to have made a workaround for actions/setup-go#393
There is a suggestion to make similar workarounds in the actions/setup-dotnet actions/setup-dotnet#260 (comment)
Hopefully we can find a solution that is more generic for all 😅
Maybe we can simply make the C drive similar to the D drive? That way there is no difference.
I assume this is most likely a small change in the packer script?
Platforms affected
Runner images affected
Image version and build link
https://github.com/jetersen/dotnet.restore.slow.github.action/actions/runs/6736383956/job/18311632176
https://github.com/jetersen/dotnet.restore.slow.github.action/actions/runs/6736262624
Is it regression?
Yes/No it has been a constant regression
Expected behavior
Windows actions should be similar or only a few seconds slower not like 30 seconds more.
Actual behavior
Depending on IO everything is significantly slower sometimes a whole minute slower or longer depending on how much IO.
Repro steps
https://github.com/jetersen/dotnet.restore.slow.github.action
The text was updated successfully, but these errors were encountered: