Skip to content

Commit

Permalink
[Mac OS] Remove hub utility (#8364)
Browse files Browse the repository at this point in the history
  • Loading branch information
vpolikarpov-akvelon authored Sep 26, 2023
1 parent 8cb738b commit 2cbf4a7
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 15 deletions.
3 changes: 0 additions & 3 deletions images/macos/provision/core/git.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ git lfs install
# Update system git config
sudo git lfs install --system

echo Installing Hub
brew_smart_install "hub"

echo Disable all the Git help messages...
git config --global advice.pushUpdateRejected false
git config --global advice.pushNonFFCurrent false
Expand Down
7 changes: 1 addition & 6 deletions images/macos/software-report/SoftwareReport.Common.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,6 @@ function Get-GitHubCLIVersion {
return $ghVersion
}

function Get-HubVersion {
$hubVersion = Run-Command "brew list --versions hub" | Take-Part -Part 1
return $hubVersion
}

function Get-WgetVersion {
$wgetVersion = Run-Command "wget --version" | Select-String "GNU Wget" | Take-Part -Part 2
return $wgetVersion
Expand Down Expand Up @@ -634,4 +629,4 @@ function Get-ColimaVersion {
function Get-PKGConfigVersion {
$pkgconfigVersion = Run-Command "pkg-config --version"
return $pkgconfigVersion
}
}
1 change: 0 additions & 1 deletion images/macos/software-report/SoftwareReport.Generator.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ if ($os.IsBigSur) {
$utilities.AddToolVersion("helm", $(Get-HelmVersion))
}
if ((-not $os.IsVentura) -and (-not $os.IsVenturaArm64)) {
$utilities.AddToolVersion("Hub CLI", $(Get-HubVersion))
$utilities.AddToolVersion("ImageMagick", $(Get-ImageMagickVersion))
}
$utilities.AddToolVersion("jq", $(Get-JqVersion))
Expand Down
5 changes: 0 additions & 5 deletions images/macos/tests/Git.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,3 @@ Describe "Git" {
"git lfs version" | Should -ReturnZeroExitCode
}
}
Describe "hub CLI" -Skip:($os.IsVentura -or $os.IsVenturaArm64) {
It "hub CLI is installed" {
"hub --version" | Should -ReturnZeroExitCode
}
}

0 comments on commit 2cbf4a7

Please sign in to comment.