Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/github to 2.2.0 to support GHES #72

Merged
merged 2 commits into from
May 15, 2020

Conversation

pjquirk
Copy link
Contributor

@pjquirk pjquirk commented May 14, 2020

This adds support for running against GHES by using v2.2.0 of @actions/github. The details of connecting to a GHES instance or github.com are handled internally in the client, so no code changes in this action are necessary.

Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set NODE_TLS_REJECT_UNAUTHORIZED = 0 temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.

@pjquirk pjquirk requested a review from dakale May 14, 2020 20:57
@pjquirk
Copy link
Contributor Author

pjquirk commented May 14, 2020

I had to make a few small changes to account for the octokit upgrade. Changes are here, since the files changed tab is a nightmare.

Copy link
Contributor

@dakale dakale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can you going to push an updated v2 tag after this is merged?

@pjquirk pjquirk merged commit c5c9bd0 into releases/v2 May 15, 2020
@pjquirk
Copy link
Contributor Author

pjquirk commented May 15, 2020

@pje pje deleted the users/paquirk/v2ghesfixes branch June 29, 2021 15:08
@Amoon-123
Copy link

on : push
jobs :
test :
matrix : platform : [ ubuntu-latest، macos-latest، windows-latest]
التشغيل : $ {matrix.platform}}
الخطوات :
- الاستخدامات : Actions / checkout @ v3

- يستخدم : Actions / setup-node @ v3
   مع : 
    إصدار العقدة : 16
- تشغيل : npm install-ci-test
- الاستخدامات :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants