New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double negation message typo #629

Merged

MaksimZhukov merged 2 commits into actions:main from TrianguloY:patch-1

Jul 31, 2023

Contributor

TrianguloY commented Jul 25, 2023

Description:
Fix double negation typo on the file not found error message:

-The configuration file (path: /) isn't not found locally, fetching via the api
+The configuration file (path: /) was not found locally, fetching via the api

Note: I also changed the positive message for consistency, but I can revert if needed.

-The configuration file (path: /) is found locally, reading from the file
+The configuration file (path: /) was found locally, reading from the file

No documentation changes are required.

No tests were modified.

Related issue:

None

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.


          Fix double negation typo

4e067fd

TrianguloY requested a review from a team as a code owner

July 25, 2023 10:04

Contributor

MaksimZhukov commented Jul 25, 2023

Hello @TrianguloY!
Thank you for noticing this!
Could you please rebuild the index.js file?


          Rebuild index.js

0a3bcff

Contributor Author

TrianguloY commented Jul 25, 2023

Oh, sorry, I made the change from the GitHub interface and didn't realize you don't have automatic actions to build it.

Done (I hope).
Just let me know if there is anything else I need to change!

MaksimZhukov approved these changes

View reviewed changes

dmitry-shibanov approved these changes

View reviewed changes

IvanZosimov approved these changes

View reviewed changes

MaksimZhukov merged commit 5bb656d into actions:main

Contributor

MaksimZhukov commented Jul 31, 2023

@TrianguloY thank you for the pull request!

Contributor Author

TrianguloY commented Jul 31, 2023

@TrianguloY thank you for the pull request!

You're welcome 😊

kingthorin commented Sep 29, 2023

Thanks for fixing this. I noticed the message today and came to fix it, just to find it done 😀

sp3nx0r referenced this pull request in sp3nx0r/homelab


          feat(github-action)!: Update actions/labeler action to v5.0.0 (#10)

7c85b48

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/labeler](https://github.com/actions/labeler) | action |
major | `v4.3.0` -> `v5.0.0` |

---

### Release Notes

<details>
<summary>actions/labeler (actions/labeler)</summary>

### [`v5.0.0`](https://github.com/actions/labeler/releases/tag/v5.0.0)

[Compare
Source](https://github.com/actions/labeler/compare/v4.3.0...v5.0.0)

#### What's Changed

This release contains the following breaking changes:

1. The ability to apply labels based on the names of base and/or head
branches was added
([#&#8203;186](https://github.com/actions/labeler/issues/186) and
[#&#8203;54](https://github.com/actions/labeler/issues/54)). The match
object for changed files was expanded with new combinations in order to
make it more intuitive and flexible
([#&#8203;423](https://github.com/actions/labeler/issues/423) and
[#&#8203;101](https://github.com/actions/labeler/issues/101)). As a
result, the configuration file structure was significantly redesigned
and is not compatible with the structure of the previous version. Please
read the [action
documentation](https://github.com/actions/labeler/tree/main#pull-request-labeler)
to find out how to adapt your configuration files for use with the new
action version.

2. The bug related to the `sync-labels` input was fixed
([#&#8203;112](https://github.com/actions/labeler/issues/112)). Now
the input value is read correctly.

3. By default, `dot` input is set to `true`. Now, paths starting with a
dot (e.g. `.github`) are matched by default.

4. Version 5 of this action updated the [runtime to Node.js
20](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions).
All scripts are now run with Node.js 20 instead of Node.js 16 and are
affected by any breaking changes between Node.js 16 and 20.

For more information, please read the [action
documentation](https://github.com/actions/labeler/tree/main#pull-request-labeler).

#### New Contributors

- [@&#8203;joshdales](https://github.com/joshdales) made their first
contribution in
[https://github.com/actions/labeler/pull/203](https://github.com/actions/labeler/pull/203)
- [@&#8203;dusan-trickovic](https://github.com/dusan-trickovic) made
their first contribution in
[https://github.com/actions/labeler/pull/626](https://github.com/actions/labeler/pull/626)
- [@&#8203;sungh0lim](https://github.com/sungh0lim) made their first
contribution in
[https://github.com/actions/labeler/pull/630](https://github.com/actions/labeler/pull/630)
- [@&#8203;TrianguloY](https://github.com/TrianguloY) made their first
contribution in
[https://github.com/actions/labeler/pull/629](https://github.com/actions/labeler/pull/629)

**Full Changelog**:
actions/labeler@v4...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/sp3nx0r/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet