Early exit when no files are changed.

[nathanhammond]

As a consequence of the checkAll function call returning true if the length of changedFiles is 0, this must early-exit in order to avoid labeling empty PRs.

Example labeling failure here: vercel/turborepo#2706

[nathanhammond]

The source of the error is here:

labeler/src/labeler.ts

Lines 202 to 214 in 5c75392

	function checkAll(changedFiles: string[], globs: string[]): boolean {
	const matchers = globs.map((g) => new Minimatch(g));
	core.debug(` checking "all" patterns`);
	for (const changedFile of changedFiles) {
	if (!isMatch(changedFile, matchers)) {
	core.debug(` "all" patterns did not match against ${changedFile}`);
	return false;
	}
	}
	core.debug(` "all" patterns matched all files`);
	return true;
	}

The loop on lines 205-210 does not execute and therefore the checkAll check returns true.

[nathanhammond]

Rebased and updated to match new code style. As all changes were formatting, the dist asset didn't change.

[nathanhammond]

Updated and rebuilt.

[Samriel]

Hello @nathanhammond! Could you please tell me, how do you create an empty PR? The link you provided as a labeler failure leads to a pull request. If you could provide the link with the run in which labeler failed - that would help me investigate the issue.

[nathanhammond]

@AndreiLobanovich I didn't create the PR that failed and it has changed a lot since then. I did see the consequences of the failure. You can review the tests that I added to demonstrate the failure in the event there are no changed files. Two commits with a net result of zero changes would probably do it?

(I wouldn't have filed this PR without having seen it fail once. 😜 I wouldn't have known to go look!)

[Samriel]

Hello, @nathanhammond!
Thanks for your contribution and attention to details! I managed to reproduce the incorrect behavior. Could you please make a few minor changes?

[Samriel]

Hi @nathanhammond ,

I hope this message finds you well. I wanted to check in and see how you're progressing with this PR.

Please feel free to let me know if you need any assistance or if there's anything that you're unsure of. We greatly appreciate your contribution and are here to support you in any way we can.

Thank you for your time and effort.

[Samriel]

Hello, @nathanhammond!

Didn't hear from you for a while. Do you have some spare time to finish work on this PR? Is there anything I can help you with?

[Samriel]

Hey, @nathanhammond, we miss you a lot. If you could find some spare time to finish work on this PR that would be great.
Hope you are doing well.

[MaksimZhukov]

@nathanhammond thank you for the contribution!