Skip to content

Go Download URL change#127

Merged
HarithaVattikuti merged 1 commit intoactions:mainfrom
HarithaVattikuti:Gourlchange
Dec 3, 2025
Merged

Go Download URL change#127
HarithaVattikuti merged 1 commit intoactions:mainfrom
HarithaVattikuti:Gourlchange

Conversation

@HarithaVattikuti
Copy link
Copy Markdown
Contributor

The storage.googleapis.com/golang URLs were originally used prior to Go's migration to a CDN in 2017 and are no longer intended for ongoing use. Downloading files from these URLs is unsupported and may not remain reliable.

This PR updates the URLs to use the official Go downloads page (https://go.dev/dl/), which provides current and supported links for Go release files.

Copilot AI review requested due to automatic review settings December 2, 2025 17:18
@HarithaVattikuti HarithaVattikuti requested a review from a team as a code owner December 2, 2025 17:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go download URL from the deprecated storage.googleapis.com/golang endpoint to the official and supported https://go.dev/dl/ CDN. The old googleapis.com URLs have been unsupported since Go's CDN migration in 2017 and may no longer be reliable.

Key Changes:

  • Updated the GetBinariesUri() method in GoBuilder class to use the official Go CDN URL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thaJeztah
Copy link
Copy Markdown

Looks like this started breaking indeed;

Setup go version spec 1.25.5
Attempting to download 1.25.5...
matching 1.25.5...
Not found in manifest.  Falling back to download directly from Go
Install from dist
Acquiring go1.25.5 from [https://storage.googleapis.com/golang/go1.25.5.windows-amd64.zip](https://storage.googleapis.com/golang/go1.25.5.windows-amd64.zip)
Error: Failed to download version 1.25.5: Error: Unexpected HTTP response: 403

@tforbes-cw
Copy link
Copy Markdown

Confirmed

~$ curl -s -o /dev/null -L -w "%{http_code}\n" https://storage.googleapis.com/golang/go1.24.11.src.tar.gz
403

~$ curl -s -o /dev/null -L -w "%{http_code}\n" https://go.dev/dl/go1.24.11.src.tar.gz
200

@rpmoore
Copy link
Copy Markdown

rpmoore commented Dec 2, 2025

Looks like this started breaking indeed;

Setup go version spec 1.25.5
Attempting to download 1.25.5...
matching 1.25.5...
Not found in manifest.  Falling back to download directly from Go
Install from dist
Acquiring go1.25.5 from [https://storage.googleapis.com/golang/go1.25.5.windows-amd64.zip](https://storage.googleapis.com/golang/go1.25.5.windows-amd64.zip)
Error: Failed to download version 1.25.5: Error: Unexpected HTTP response: 403

We hit this as well.

@HarithaVattikuti HarithaVattikuti merged commit 5c18eb3 into actions:main Dec 3, 2025
22 checks passed
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Dec 3, 2025
Due to the removal of storage.googleapis.com/golang
(actions/go-versions#127),
some of the golang installs are failing, so  update setup-go action
to 6.1.0 which has a fix for this:
https://github.com/actions/setup-go/releases/tag/v6.1.0

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to confidential-containers/cloud-api-adaptor that referenced this pull request Dec 3, 2025
Due to the removal of storage.googleapis.com/golang
(actions/go-versions#127),
some of the golang installs are failing, so  update setup-go action
to 6.1.0 which has a fix for this:
https://github.com/actions/setup-go/releases/tag/v6.1.0

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
christophetd added a commit to DataDog/stratus-red-team that referenced this pull request Dec 11, 2025
christophetd added a commit to DataDog/stratus-red-team that referenced this pull request Dec 11, 2025
* Fix setup-go GitHub Action

per actions/go-versions#127

* Add dl.google.com as an allowed domain

* Bump Go version in tests to 1.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants