Add base-url option #429

robandpdx · 2023-10-20T16:17:39Z

Resolves #428

action.yml

src/main.ts

Co-authored-by: Josh Gross <[email protected]>

gustavkj · 2023-11-16T14:51:34Z

Ironically, this broke workflows on Github Enterprise. I think the undefined value still will be interpreted as the value being set.

It worked before without any extra config, since Github Enterprise set the GITHUB_API_URL environment variable (just like Github.com, see docs) and it used by the @actions/github package to set the base url here: https://github.com/actions/toolkit/blob/20f826bfe76164099ab2403d9ea8509e16843223/packages/github/src/internal/utils.ts#L42-L44

One solution would be to set a default value to be the pre-configured value, or fix the assignment to the opts object only when it is set.

I've opened a bug: #436

Bumps [actions/github-script](https://github.com/actions/github-script) from 6.4.0 to 7.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/github- script/releases">actions/github-script's releases</a>.</em></p> <blockquote> <h2>v7.0.1</h2> <h2>What's Changed</h2> <ul> <li>Avoid setting <code>baseUrl</code> to undefined when input is not provided by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://github.com/actions/github- script/pull/439">actions/github-script#439</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github- script/compare/v7.0.0...v7.0.1">https://github.com/actions/github- script/compare/v7.0.0...v7.0.1</a></p> <h2>v7.0.0</h2> <h2>What's Changed</h2> <ul> <li>Add base-url option by <a href="https://github.com/robandpdx"><code>@robandpdx</code></a> in <a href="https://github.com/actions/github- script/pull/429">actions/github-script#429</a></li> <li>Expose async-function argument type by <a href="https://github.com/viktorlott"><code>@viktorlott</code></a> in <a href="https://github.com/actions/github- script/pull/402">actions/github-script#402</a>, see for details <a href="https://github.com/actions/github-script#use-scripts-with-jsdoc- support">https://github.com/actions/github-script#use-scripts-with- jsdoc-support</a></li> <li>Update dependencies and use Node 20 by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://github.com/actions/github- script/pull/425">actions/github-script#425</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/navarroaxel"><code>@navarroaxel</code></a> made their first contribution in <a href="https://github.com/actions/github- script/pull/285">actions/github-script#285</a></li> <li><a href="https://github.com/robandpdx"><code>@robandpdx</code></a> made their first contribution in <a href="https://github.com/actions/github- script/pull/429">actions/github-script#429</a></li> <li><a href="https://github.com/viktorlott"><code>@viktorlott</code></a> made their first contribution in <a href="https://github.com/actions/github- script/pull/402">actions/github-script#402</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github- script/compare/v6.4.1...v7.0.0">https://github.com/actions/github- script/compare/v6.4.1...v7.0.0</a></p> <h2>v6.4.1</h2> <h2>What's Changed</h2> <ul> <li>Add <code>@octokit/plugin-request-log</code>, to produce debug output for requests by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://github.com/actions/github- script/pull/358">actions/github-script#358</a></li> <li>fix input handling by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://github.com/actions/github- script/pull/357">actions/github-script#357</a></li> <li>Remove unused dependencies by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://github.com/actions/github- script/pull/356">actions/github-script#356</a></li> <li>Default debug to current runner debug state by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://github.com/actions/github- script/pull/363">actions/github-script#363</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/mjpieters"><code>@mjpieters</code></a> made their first contribution in <a href="https://github.com/actions/github- script/pull/358">actions/github-script#358</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github- script/compare/v6.4.0...v6.4.1">https://github.com/actions/github- script/compare/v6.4.0...v6.4.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="actions/github-script@60a0d83039c 74a4aee543508d2ffcb1c3799cdea"><code>60a0d83</code></a> Merge pull request <a href="https://github.com/actions/github- script/issues/440">sagemath#440</a> from actions/joshmgross/v7.0.1</li> <li><a href="actions/github-script@b7fb2001b41 0c9390cbe9e2c7d5cab7eefb7b29c"><code>b7fb200</code></a> Update version to 7.0.1</li> <li><a href="actions/github-script@12e22ed06b6 cf302663f90a925045516e24c8bad"><code>12e22ed</code></a> Merge pull request <a href="https://github.com/actions/github- script/issues/439">sagemath#439</a> from actions/joshmgross/avoid-setting-base- url</li> <li><a href="actions/github-script@d319f8f5b55 ea40916b869b2ca9ae2f059c60abf"><code>d319f8f</code></a> Avoid setting <code>baseUrl</code> to undefined when input is not provided</li> <li><a href="actions/github-script@e69ef5462fd 455e02edcaf4dd7708eda96b9eda0"><code>e69ef54</code></a> Merge pull request <a href="https://github.com/actions/github- script/issues/425">sagemath#425</a> from actions/joshmgross/node-20</li> <li><a href="actions/github-script@ee0914b839b 704083a749f8c77a73a9270674a32"><code>ee0914b</code></a> Update licenses</li> <li><a href="actions/github-script@d6fc56f33b0 17d55917d045da1a94efa2120f039"><code>d6fc56f</code></a> Use <code>@types/node</code> for Node 20</li> <li><a href="actions/github-script@384d6cf5814 52587d1e31f553c97ab165427124a"><code>384d6cf</code></a> Fix quotations in tests</li> <li><a href="actions/github-script@84724927e3e 992f17768c17f57a47a85ea2a5160"><code>8472492</code></a> Only validate GraphQL <code>previews</code></li> <li><a href="actions/github-script@84903f51828 821af5d03d3884c6ba699a2d44d6e"><code>84903f5</code></a> Remove <code>node-fetch</code> from type</li> <li>Additional commits viewable in <a href="https://github.com/actions/github- script/compare/v6.4.0...v7.0.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency- name=actions/github-script&package-manager=github_actions&previous- version=6.4.0&new- version=7.0.1)](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#36739 Reported by: dependabot[bot] Reviewer(s): Kwankyu Lee

add base-url option

ea121b8

robandpdx requested a review from a team as a code owner October 20, 2023 16:17

joshmgross reviewed Oct 20, 2023

View reviewed changes

action.yml Outdated Show resolved Hide resolved

src/main.ts Outdated Show resolved Hide resolved

robandpdx temporarily deployed to debug-integration-test October 20, 2023 21:27 — with GitHub Actions Inactive

robandpdx and others added 2 commits October 23, 2023 16:35

generate dist changes for addition of base-url

e8957ff

Update action.yml

ef8023a

Co-authored-by: Josh Gross <[email protected]>

robandpdx temporarily deployed to debug-integration-test October 23, 2023 23:37 — with GitHub Actions Inactive

add example to description of base-url parameter

5940a76

joshmgross approved these changes Oct 23, 2023

View reviewed changes

robandpdx temporarily deployed to debug-integration-test October 23, 2023 23:48 — with GitHub Actions Inactive

joshmgross merged commit 6b5d3ea into actions:main Oct 31, 2023
13 checks passed

robandpdx deleted the add-base-url-option branch October 31, 2023 19:34

gustavkj mentioned this pull request Nov 16, 2023

Goes incorrectly toward api.github.com on Github Enterprise after upgrading to v7 #436

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add base-url option #429

Add base-url option #429

robandpdx commented Oct 20, 2023

gustavkj commented Nov 16, 2023 •

edited

Loading

Add base-url option #429

Add base-url option #429

Conversation

robandpdx commented Oct 20, 2023

gustavkj commented Nov 16, 2023 • edited Loading

gustavkj commented Nov 16, 2023 •

edited

Loading