Use @actions/github to invoke GraphQL for GHES compatibility #16
Conversation
|
👋 I'm working on updating in-the-box actions for GHES. Note, I was able to test the changes successfully against dotcom but doesnt look like packages is enabled on my local GHES deployment. |
| import {catchError, map, tap} from 'rxjs/operators' | ||
| import {GraphQlQueryResponse} from '@octokit/graphql/dist-types/types' | ||
| import {graphql} from './graphql' |
There was a problem hiding this comment.
To enable mocking, i switched to importing a local file instead. The problem is @actions/github exports a class which introduces a challenge for mocking... solved by adding one more level of indirection :)
| * @param {string} query GraphQL query. Example: `'query { viewer { login } }'`. | ||
| * @param {object} parameters URL, query or body parameters, as well as `headers`, `mediaType.{format|previews}`, `request`, or `baseUrl`. | ||
| */ | ||
| export async function graphql( |
There was a problem hiding this comment.
wrapper function to make it easy to mock. Otherwise hard to mock since GitHub is an exported class.
ericsciple
force-pushed
the
users/ericsciple/m262ghes
branch
from
b26a883
to
f4a606f
Compare
ericsciple
changed the title
|
@trent-j thanks! Would you be able to merge and release? I dont have permission. With these changes, it should just work, once Packages is in GHES. |
|
I end-to-end tested the scenario where it discovers old packages and deletes. I believe that exercises all of the cases where GraphQL is invoked (get version + delete). |
Switched to
@actions/[email protected]for GHES support when invoking GraphQL. It sets the correct baseUrl when running in a GHES environment. Related to PR actions/toolkit#449