Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 16 #689

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Update to node 16 #689

merged 4 commits into from
Feb 28, 2022

Conversation

thboop
Copy link
Contributor

@thboop thboop commented Feb 7, 2022

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

@thboop thboop requested a review from ericsciple February 7, 2022 18:56
ericsciple
ericsciple reviewed Feb 28, 2022
View reviewed changes
action.yml
@@ -69,6 +69,6 @@ inputs:
converted to HTTPS.
default: false
runs:
using: node12
using: node16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we concerned about older GHES + GitHub Connect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will major version these changes, so users using GitHub Connect can stay pinned on @v2 so if they are on a very old GHES version their workflows will still run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also discussed offline. sounds like this is the same plan we're using across all in-the-box actions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what to do

ericsciple
ericsciple reviewed Feb 28, 2022
View reviewed changes
.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 16.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any cases where we will fallback to node12? Wondering whether worth having a test matrix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at this moment, the version defined in the action.yaml is the version we use. Once we release a new major version, I can update this and the readme to include more testing (we can cut a releases/v2 branch to mirror our v1 branch) and test both that and the main branch

@thboop thboop merged commit 8f9e05e into main Feb 28, 2022
@thboop thboop deleted the thboop/updatenode16 branch February 28, 2022 21:17
@crazy-max crazy-max mentioned this pull request Mar 1, 2022
Closed
@jglick
Copy link

jglick commented Mar 2, 2022

Please consider adding some note to https://github.com/actions/checkout/releases/tag/v3.0.0 explaining what practical impact this might have on users that would justify the major version bump. actions/setup-java#290 (comment) has more discussion.

cabdiiidle11
cabdiiidle11 reviewed Mar 7, 2022
View reviewed changes
Copy link

@cabdiiidle11 cabdiiidle11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2000

@SuperSandro2000
Copy link

Please consider adding some note to v3.0.0 (release) explaining what practical impact this might have on users that would justify the major version bump. actions/setup-java#290 (comment) has more discussion.

Yes please. Otherwise this looks like a pointless major bump which triggers thousands of dependabot pull requests.

@thboop thboop mentioned this pull request Mar 16, 2022
Merged
34 tasks
@jglick
Copy link

jglick commented Mar 22, 2022

(There is #708 but that is not displayed as part of Dependabot PRs.)

calbearox
calbearox reviewed Mar 31, 2022
View reviewed changes
Copy link

@calbearox calbearox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

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

@SuperSandro2000
Copy link

Nice token you have there. I would recommend to revoke it.

@eregon eregon mentioned this pull request Mar 31, 2022
Merged
@lhunath lhunath mentioned this pull request Apr 4, 2022
Closed
@bjorn3 bjorn3 mentioned this pull request Apr 30, 2022
Merged
@obulat obulat mentioned this pull request May 17, 2022
Merged
1 task
@striezel striezel mentioned this pull request May 19, 2022
Merged
@striezel striezel mentioned this pull request Jun 4, 2022
Merged
This was referenced Jun 14, 2022
Merged
Merged
Merged
Merged
@striezel striezel mentioned this pull request Jul 2, 2022
Merged
@glukki glukki mentioned this pull request Aug 14, 2022
Closed
thomasmerz added a commit to thomasmerz/productive-box that referenced this pull request Dec 13, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
a3ed09e 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master

.
thomasmerz added a commit to thomasmerz/productive-box that referenced this pull request Dec 13, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
02d4142 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master

.
thomasmerz added a commit to thomasmerz/productive-box that referenced this pull request Dec 13, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
3201c2b 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master
thomasmerz added a commit to thomasmerz/activity-box that referenced this pull request Dec 13, 2022
@thomasmerz
🩹 fix deprecation warning:
36ec081 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@v2

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/thomasmerz that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
0178c5c 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@v2

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/pihole_adlist_tool that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
bc6fec8 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/pihole_adlist_tool that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
bec8917 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
This was referenced Dec 14, 2022
Merged
Merged
thomasmerz added a commit to thomasmerz/fork-serl-syncthing-quick-status that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
9336f89 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
@thomasmerz thomasmerz mentioned this pull request Dec 14, 2022
Merged
thomasmerz added a commit to thomasmerz/fork-vim-airline that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
13f3478 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
@thomasmerz thomasmerz mentioned this pull request Dec 14, 2022
Merged
thomasmerz added a commit to thomasmerz/rear that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
460ac81 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@v2

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/rear that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
7fb940b 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@v2

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/pihole_adlist_tool that referenced this pull request Dec 14, 2022
@thomasmerz
🩹 fix deprecation warning:
a44d6f4 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
serl pushed a commit to serl/syncthing-quick-status that referenced this pull request Dec 15, 2022
@thomasmerz
🩹 fix deprecation warning: (#14)
9076da1 
Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689
izayl pushed a commit to izayl/spotify-box that referenced this pull request Dec 23, 2022
@thomasmerz @izayl
🩹 fix deprecation warning:
974f038 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@v2

   Using version v3, latest or master: actions/checkout#689
thomasmerz added a commit to thomasmerz/productive-box that referenced this pull request Dec 23, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
093505a 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master
thomasmerz added a commit to thomasmerz/productive-box that referenced this pull request Dec 23, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
66e37e8 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master
pirj pushed a commit to rubocop/rubocop-capybara that referenced this pull request Dec 29, 2022
@ydah
Update actions/checkout version to v3
74705a9 
The version 3.x appears to be due to the following:
- actions/checkout#689

There have been no breaking changes,
and we seem to have no problem keeping up with the latest version.
J0WI added a commit to nextcloud/docker that referenced this pull request Jan 17, 2023
@thomasmerz @J0WI
🩹 fix deprecation warning: Node.js 12 actions are deprecated. (#1885)
c66b03b 
* 🩹 fix deprecation warning:

   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689

Signed-off-by: Thomas Merz <[email protected]>

* Update .github/workflows/update-sh.yml

Co-authored-by: J0WI <[email protected]>
Signed-off-by: thomasmerz <[email protected]>

Signed-off-by: Thomas Merz <[email protected]>
Signed-off-by: thomasmerz <[email protected]>
Co-authored-by: J0WI <[email protected]>
This was referenced Jan 31, 2023
Closed
Merged
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Apr 13, 2023
@ydah
Update actions/checkout version to v3
4483de7 
The version 3.x appears to be due to the following:
- actions/checkout#689

There have been no breaking changes,
and we seem to have no problem keeping up with the latest version.
@swiing swiing mentioned this pull request Apr 26, 2023
Closed
@TWiStErRob TWiStErRob mentioned this pull request Oct 25, 2023
Closed
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024
@ydah
Update actions/checkout version to v3
97961c9 
The version 3.x appears to be due to the following:
- actions/checkout#689

There have been no breaking changes,
and we seem to have no problem keeping up with the latest version.
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024
@ydah
Update actions/checkout version to v3
fb3c37b 
The version 3.x appears to be due to the following:
- actions/checkout#689

There have been no breaking changes,
and we seem to have no problem keeping up with the latest version.
ananace pushed a commit to ananace/docker-nextcloud that referenced this pull request May 10, 2024
@thomasmerz @J0WI @ananace
🩹 fix deprecation warning: Node.js 12 actions are deprecated. (nextcl…
22a2294 
…oud#1885)

* 🩹 fix deprecation warning:

   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
   Please update the following actions to use Node.js 16: actions/checkout@master

   Using version v3, latest or master: actions/checkout#689

Signed-off-by: Thomas Merz <[email protected]>

* Update .github/workflows/update-sh.yml

Co-authored-by: J0WI <[email protected]>
Signed-off-by: thomasmerz <[email protected]>

Signed-off-by: Thomas Merz <[email protected]>
Signed-off-by: thomasmerz <[email protected]>
Co-authored-by: J0WI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabdiiidle11 cabdiiidle11 cabdiiidle11 left review comments

@calbearox calbearox calbearox left review comments

@urica12 urica12 urica12 left review comments

@ericsciple ericsciple ericsciple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thboop @jglick @SuperSandro2000 @ericsciple @urica12 @calbearox @cabdiiidle11