include more detail in error logging #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
commented
May 9, 2024
Comment on lines
-89
to
+90
| err instanceof Error ? err.message : /* istanbul ignore next */ `${err}` | ||
| err instanceof Error ? err : /* istanbul ignore next */ `${err}` |
There was a problem hiding this comment.
Passing the entire Error object causes the error class to be displayed in the output.
bdehamer
commented
May 9, 2024
Comment on lines
-95
to
+99
| core.debug(innerErr instanceof Error ? innerErr.message : `${innerErr}}`) | ||
| core.info( | ||
| mute(innerErr instanceof Error ? innerErr.toString() : `${innerErr}`) | ||
| ) |
There was a problem hiding this comment.
Switching from debug to info so the inner error is always displayed (if available).
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/error-detail
branch
from
a740a55
to
ddbcc86
Compare
malancas
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error logging to include the name of the specific error which was thrown as well as details about any wrapped errors (if available). Previously, the user would have to enable step debug logging to get this level of detail.
Before:
After: