-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add allow-permissions #46
Conversation
🎊 PR Preview f9b6c63 has been successfully built and deployed to https://actions-cool-issues-helper-preview-pr-46.surge.sh 🕐 Build time: 78.335s 🤖 By surge-preview |
I think better named Do you think default value should be |
OK 我今晚改一下,换成 你的想法是 不过 这个 action https://github.com/mui-org/material-ui 在用,当时他们没有考虑到 用户权限的问题,如果不传就默认 admin write,会对他们造成影响。虽然他们在用的时候,只有 member 在回复。 |
发布2.0 |
|
可以,正有此意。 我晚上弄好了,再更新你那的 PR。 |
另外更新 Prettier Pr 的时候, 写死版本号, 我们都用固定版本, 有 bot 会更新. |
admin 是不是一定有 write? 然后 write 是不是一定有 read? 那是不是只要 write 就包含了 admin? |
如果这样, require-write-permission boolean 就可以了, 默认 true |
admin 是一定有 write,但是在用 API 查看 某个 user 的时候,结果是一个确定的值。 |
我可以 人为来控制 |
那确定用 require-write-permission |
我觉得够了,应该不会有repo会要求只能admin吧 |
其实我更倾向于 require-permission 可配置,默认 write 以上 |
都可以 |
🤔 这个变动的性质是?/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
allow-permissions 可选值为 admin, write, read, and none.
📝 更新日志 / Changelog
☑️ 请求合并前的自查清单 / Self Check before Merge