Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: body null #123

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix: body null #123

merged 2 commits into from
Oct 19, 2022

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Oct 19, 2022

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

fix #120

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English fix body null case
🇨🇳 Chinese

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-123.surge.sh

@xrkffgg xrkffgg merged commit 1cb0eed into main Oct 19, 2022
@xrkffgg xrkffgg deleted the fix/null branch October 19, 2022 13:10
@@ -9,7 +9,7 @@ export const dealRandomAssignees = (assignees: string, randomTo: string | void):
return arr;
};

export const matchKeyword = (content: string, keywords: string[]): boolean => {
export const matchKeyword = (content: string = '', keywords: string[]): boolean => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually didn't resolve anything. The issue still exists.
Error: [🚨 AC] Cannot read properties of null (reading 'toLowerCase') on v3.3.2 for issue with empty body and

...
        with:
          actions: 'check-issue'
          body-includes: '###,Overview'

@madmansn0w madmansn0w mentioned this pull request Nov 12, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Cannot read property 'toLowerCase' of null" - empty issue bodies cause error when using 'check-issue'
3 participants