Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get-issue #114

Merged
merged 7 commits into from
Sep 2, 2022
Merged

feat: add get-issue #114

merged 7 commits into from
Sep 2, 2022

Conversation

timeTravelCYN
Copy link
Contributor

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

#113

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese feat: add get-issue

@github-actions
Copy link

github-actions bot commented Aug 29, 2022

🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-114.surge.sh

export async function doGetIssue() {
const issue = await ICE.getIssue();
core.info(`[doGetIssue] success!`);
core.setOutput('issue', JSON.stringify(issue));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我倾向于 直接导出 title body number 之类的。。。。

另外 labels assignees 是数组,最好处理下

外面的 action.yml 要定义输出

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrkffgg 数组处理成什么格式呢~'xx1,xx2' 还是把数据提取出来 ['xx1', 'xx2']

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrkffgg 修改了一版,辛苦再看一下

@xrkffgg
Copy link
Member

xrkffgg commented Aug 31, 2022

  1. 打算是这么 返回的
    image

  2. 这个算是个 基础能力,放到 base 里

  3. labels assignees 返回像 issues 里提出的那样

@xrkffgg xrkffgg merged commit e348bdd into actions-cool:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants