improve(GasPriceOracle): Remove eip1559Bad and lineaEthers adapters #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the default adapters today but in production we use the more accurate eip1559Raw and lineaViem variants. These were always designed to be set as the defaults following testing. The benefit is we can remove the `GAS_PRICE_EIP1559_RAW_` and `NEW_GAS_PRICE_ORACLE_` environment variables
mrice32
reviewed
Feb 6, 2025
| * @param chainId Chain ID of the provider instance. | ||
| * @returns Promise of gas price estimate object. | ||
| */ | ||
| export async function eip1559Bad( |
There was a problem hiding this comment.
Maybe a dumb question, but we don't currently use this anywhere? No chain relies on it?
Totally fine with reversing the default, but want to make sure we're not breaking anything.
There was a problem hiding this comment.
in production no, we do not use it at all
|
Note to self: before releasing this into the relayer repo we should update the default scaler values in order to acknowledge that users of the relayer might not have set these "new" or "raw" oracles and they might see unexpected fees as a result of the bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the default adapters today but in production we use the more accurate eip1559Raw and lineaViem variants. These were always designed to be set as the defaults following testing.
The benefit is we can remove the
GAS_PRICE_EIP1559_RAW_andNEW_GAS_PRICE_ORACLE_environment variablesFixes ACX-3602