Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration to deterministic relay hashes #521

Merged

Conversation

amateima
Copy link
Collaborator

@amateima amateima commented Feb 6, 2025

No description provided.

Copy link

linear bot commented Feb 6, 2025

Copy link

@melisaguevara melisaguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only one question

Comment on lines 90 to 97
await this.processDepositEvents(chainId, depositEvents);
await this.processDepositV3Events(chainId, depositV3Events);
await this.processDepositV3_5Events(chainId, depositV3_5Events);
await this.processFillEvents(chainId, fillEvents);
await this.processFillEvents(chainId, fillV3Events);
await this.processFillV3_5Events(chainId, fillV3_5Events);
await this.processSpeedUpEvents(chainId, speedUpEvents);
await this.processSpeedUpV3Events(chainId, speedUpV3Events);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need processSpeedUpV3_5Events?

@amateima amateima merged commit 59c170e into master Feb 6, 2025
2 checks passed
@amateima amateima deleted the amatei/acx-3629-scraper-query-both-the-old-and-new-events-5 branch February 6, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants