feat: implement deposit v3 events #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amateima
force-pushed
the
amatei/acx-1831-implement-fundsdeposited-v3-events
branch
from
9f672c2 to
bd6d657
Compare
added 2 commits
February 7, 2024 16:53
* fix: replace save with update (#338) Co-authored-by: amateima <[email protected]> * fix: replace save with update (#340) * fix: replace save with update * Fix --------- Co-authored-by: amateima <[email protected]> * feat: integrate v3 fill events * Add fill events consumer * Finish v3 fill events * Dix * feat: implement speedup v3 events (#341) * feat: implement speedup v3 events * Fix bugs * Fix import * Fix --------- Co-authored-by: amateima <[email protected]> --------- Co-authored-by: amateima <[email protected]>
dohaki
approved these changes
Feb 21, 2024
| @@ -93,7 +96,7 @@ export class FeeBreakdownConsumer { | |||
| relayCapitalFeePct: undefined, | |||
| relayCapitalFeeAmount: undefined, | |||
| relayGasFeeUsd, | |||
| relayGasFeePct: relayGasFeePct.toString(), | |||
| relayGasFeePct: undefined, | |||
There was a problem hiding this comment.
Hmm, why did we have to remove this?
const relayGasFeePct = new BigNumber(relayGasFeeAmount).dividedBy(deposit.amount);
doesn't work?
dohaki
reviewed
Feb 21, 2024
| import { | ||
| DepositFilledDateQueueMessage, | ||
| FeeBreakdownQueueMessage, | ||
| FillEventsQueueMessage2, |
| ScraperQueue, | ||
| } from "."; | ||
| import { InjectRepository } from "@nestjs/typeorm"; | ||
| import { Deposit, DepositFillTx2, DepositFillTxV3 } from "../../../deposit/model/deposit.entity"; |
There was a problem hiding this comment.
DepositFillTx2 can be removed
| import { OnQueueFailed, Process, Processor } from "@nestjs/bull"; | ||
| import { Logger } from "@nestjs/common"; | ||
| import { Job } from "bull"; | ||
| import { DepositFilledDateQueueMessage, SpeedUpEventsV3QueueMessage, ScraperQueue } from "."; |
There was a problem hiding this comment.
DepositFilledDateQueueMessage can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.