PIPE-6530 | Upgrade moonshot and cloud-moonshot-production-safety to Ruby 3.3.6

.gitignore

@@ -1,4 +1,3 @@
-/Gemfile.lock
 /vendor
 /coverage
 site/

.rubocop.yml

@@ -1,6 +1,7 @@
 ---
 AllCops:
-  TargetRubyVersion: 3.3.4
+  NewCops: enable
+  TargetRubyVersion: 3.3.6
   Exclude:
     - '.gemspec'
     - 'vendor/**/*'

.ruby-version

@@ -1 +1 @@
-3.3.4
+3.3.6

Gemfile

@@ -6,8 +6,18 @@ gemspec
 
 gem 'rake', require: false
 
+gem 'interactive-logger',
+    git: 'https://github.com/imnetworku/interactive-logger.git',
+    branch: 'ruby-3.3.6'
+
 group :test do
   gem 'codeclimate-test-reporter'
   gem 'pry'
   gem 'rubocop'
 end
+
+group :development do
+  gem 'fakefs'
+  gem 'rspec'
+  gem 'simplecov'
+end

Gemfile.lock

@@ -0,0 +1,212 @@
+GIT
+  remote: https://github.com/imnetworku/interactive-logger.git
+  revision: c3fdb3dec202569c32d53cb1f1d0b08d0810e801
+  branch: ruby-3.3.6
+  specs:
+    interactive-logger (0.1.4)
+      colorize
+      ruby-duration
+
+PATH
+  remote: .
+  specs:
+    moonshot (3.0.5)
+      activesupport
+      aws-sdk-autoscaling
+      aws-sdk-cloudformation
+      aws-sdk-codedeploy
+      aws-sdk-ec2
+      aws-sdk-elasticloadbalancing
+      aws-sdk-iam
+      aws-sdk-s3
+      colorize
+      faraday
+      faraday-rack
+      faraday-retry
+      highline
+      pry
+      require_all
+      retriable
+      rexml
+      rotp
+      ruby-duration
+      semantic
+      thor
+      vandamme
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (8.0.1)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    ast (2.4.2)
+    aws-eventstream (1.3.0)
+    aws-partitions (1.1029.0)
+    aws-sdk-autoscaling (1.128.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-cloudformation (1.124.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-codedeploy (1.79.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-core (3.214.0)
+      aws-eventstream (~> 1, >= 1.3.0)
+      aws-partitions (~> 1, >= 1.992.0)
+      aws-sigv4 (~> 1.9)
+      jmespath (~> 1, >= 1.6.1)
+    aws-sdk-ec2 (1.498.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-elasticloadbalancing (1.68.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-iam (1.114.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-kms (1.96.0)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sigv4 (~> 1.5)
+    aws-sdk-s3 (1.176.1)
+      aws-sdk-core (~> 3, >= 3.210.0)
+      aws-sdk-kms (~> 1)
+      aws-sigv4 (~> 1.5)
+    aws-sigv4 (1.10.1)
+      aws-eventstream (~> 1, >= 1.0.2)
+    base64 (0.2.0)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
+    codeclimate-test-reporter (1.0.7)
+      simplecov
+    coderay (1.1.3)
+    colorize (1.1.0)
+    commonmarker (0.14.15)
+      ruby-enum (~> 0.5)
+    concurrent-ruby (1.3.4)
+    connection_pool (2.4.1)
+    diff-lcs (1.5.1)
+    docile (1.4.1)
+    drb (2.2.1)
+    fakefs (2.8.0)
+    faraday (2.12.2)
+      faraday-net_http (>= 2.0, < 3.5)
+      json
+      logger
+    faraday-net_http (3.4.0)
+      net-http (>= 0.5.0)
+    faraday-rack (2.0.0)
+      faraday (~> 2.0)
+    faraday-retry (2.2.1)
+      faraday (~> 2.0)
+    github-markup (1.7.0)
+    highline (3.1.1)
+      reline
+    i18n (1.14.6)
+      concurrent-ruby (~> 1.0)
+    io-console (0.8.0)
+    iso8601 (0.13.0)
+    jmespath (1.6.2)
+    json (2.9.1)
+    language_server-protocol (3.17.0.3)
+    logger (1.6.4)
+    method_source (1.1.0)
+    minitest (5.25.4)
+    net-http (0.6.0)
+      uri
+    parallel (1.26.3)
+    parser (3.3.6.0)
+      ast (~> 2.4.1)
+      racc
+    pry (0.15.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    regexp_parser (2.10.0)
+    reline (0.6.0)
+      io-console (~> 0.5)
+    require_all (3.0.0)
+    retriable (3.1.2)
+    rexml (3.4.0)
+    rotp (6.3.0)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.2)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.2)
+    rubocop (1.69.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.36.2, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.37.0)
+      parser (>= 3.3.1.0)
+    ruby-duration (3.2.3)
+      activesupport (>= 3.0.0)
+      i18n
+      iso8601
+    ruby-enum (0.9.0)
+      i18n
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
+    semantic (1.6.1)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.1)
+    simplecov_json_formatter (0.1.4)
+    thor (1.3.2)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.1.3)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.2)
+    vandamme (0.0.12)
+      commonmarker (~> 0.14.14)
+      github-markup (~> 1.3)
+
+PLATFORMS
+  arm64-darwin-24
+  ruby
+
+DEPENDENCIES
+  codeclimate-test-reporter
+  fakefs
+  interactive-logger!
+  moonshot!
+  pry
+  rake
+  rspec
+  rubocop
+  simplecov
+
+BUNDLED WITH
+   2.5.23

lib/moonshot/artifact_repository/s3_bucket_via_github_releases.rb

@@ -219,8 +219,8 @@ def backup_failed_s3_file(s3_name, attempt)
     def doctor_check_hub_release_download
       sh_out('hub release download --help')
     rescue StandardError
-      critical '`hub release download` command missing, upgrade hub.' \
-               ' See https://github.com/github/hub/pull/1103'
+      critical '`hub release download` command missing, upgrade hub. ' \
+               'See https://github.com/github/hub/pull/1103'
     else
       success '`hub release download` command available.'
     end

lib/moonshot/build_mechanism/script.rb

@@ -29,7 +29,7 @@ def initialize(script, output_file: 'output.tar.gz')
   end
 
   def pre_build_hook(_version)
-    File.delete(@output_file) if File.exist?(@output_file)
+    FileUtils.rm_f(@output_file)
   end
 
   def build_hook(version)