Merge feature/search refactor into develop branch.#1928
Merge feature/search refactor into develop branch.#1928rajeshreeputra wants to merge 20 commits intodevelopfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the search configuration by introducing a dedicated "acquia_cms_search" settings block and migrating Acquia CMS settings from the common schema to a new structure. Key changes include:
- Introducing a new configuration mapping under "acquia_cms_common.settings" in the schema.
- Adding "acquia_cms_search" entries to various content type and field configuration files.
- Removing duplicate or legacy search_index entries from existing "acquia_cms_common" settings.
Reviewed Changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/acquia_cms_common/config/schema/acquia_cms_common.schema.yml | Moved settings from a dashed list entry to a new key and added a test‐only search block. |
| modules/acquia_cms_page/config/optional/node.type.page.yml | Added "acquia_cms_search" settings. |
| modules/acquia_cms_event/config/optional/node.type.event.yml | Added "acquia_cms_search" settings. |
| modules/acquia_cms_article/config/optional/node.type.article.yml | Added "acquia_cms_search" settings and removed a duplicate entry. |
| modules/acquia_cms_person/config/optional/node.type.person.yml | Added "acquia_cms_search" settings. |
| Remaining field storage and view configuration files | Consistently added "acquia_cms_search" settings and removed redundant keys. |
Files not reviewed (1)
- modules/acquia_cms_common/acquia_cms_common.module: Language not supported
Comments suppressed due to low confidence (1)
modules/acquia_cms_common/config/schema/acquia_cms_common.schema.yml:41
- The removal of the dash preceding the old key might affect the YAML structure if it was intended to be part of a list. Please verify that the new 'acquia_cms_common.settings' mapping is correctly integrated into the expected configuration structure.
acquia_cms_common.settings:
…categories storage exists.
80394ae to
5a5e24b
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
Motivation
Merge
feature/search-refactorintodevelopbranch.Proposed changes
Search refactor:
Alternatives considered
NA
Testing steps
Merge requirements