Skip to content

Merge feature/search refactor into develop branch.#1928

Closed
rajeshreeputra wants to merge 20 commits intodevelopfrom
feature/search-refactor
Closed

Merge feature/search refactor into develop branch.#1928
rajeshreeputra wants to merge 20 commits intodevelopfrom
feature/search-refactor

Conversation

@rajeshreeputra
Copy link
Contributor

@rajeshreeputra rajeshreeputra commented Feb 10, 2025

Motivation

Merge feature/search-refactor into develop branch.

Proposed changes
Search refactor:

  • Update third party settings
  • Move code related to search from Common module to Search module.
  • Update tests accordingly
  • Update search to support recipe.

Alternatives considered
NA

Testing steps

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the search configuration by introducing a dedicated "acquia_cms_search" settings block and migrating Acquia CMS settings from the common schema to a new structure. Key changes include:

  • Introducing a new configuration mapping under "acquia_cms_common.settings" in the schema.
  • Adding "acquia_cms_search" entries to various content type and field configuration files.
  • Removing duplicate or legacy search_index entries from existing "acquia_cms_common" settings.

Reviewed Changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/acquia_cms_common/config/schema/acquia_cms_common.schema.yml Moved settings from a dashed list entry to a new key and added a test‐only search block.
modules/acquia_cms_page/config/optional/node.type.page.yml Added "acquia_cms_search" settings.
modules/acquia_cms_event/config/optional/node.type.event.yml Added "acquia_cms_search" settings.
modules/acquia_cms_article/config/optional/node.type.article.yml Added "acquia_cms_search" settings and removed a duplicate entry.
modules/acquia_cms_person/config/optional/node.type.person.yml Added "acquia_cms_search" settings.
Remaining field storage and view configuration files Consistently added "acquia_cms_search" settings and removed redundant keys.
Files not reviewed (1)
  • modules/acquia_cms_common/acquia_cms_common.module: Language not supported
Comments suppressed due to low confidence (1)

modules/acquia_cms_common/config/schema/acquia_cms_common.schema.yml:41

  • The removal of the dash preceding the old key might affect the YAML structure if it was intended to be part of a list. Please verify that the new 'acquia_cms_common.settings' mapping is correctly integrated into the expected configuration structure.
acquia_cms_common.settings:

rajeshreeputra and others added 20 commits April 3, 2025 23:09
@vishalkhode1 vishalkhode1 force-pushed the feature/search-refactor branch from 80394ae to 5a5e24b Compare April 3, 2025 19:32
@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@acquia-stalebot-platauto acquia-stalebot-platauto bot deleted the feature/search-refactor branch May 13, 2025 03:54
@rajeshreeputra rajeshreeputra restored the feature/search-refactor branch July 25, 2025 12:41
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment July 25, 2025 12:41 — with GitHub Actions Inactive
@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@acquia-stalebot-platauto acquia-stalebot-platauto bot deleted the feature/search-refactor branch October 4, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants