Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create yaml files #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

create yaml files #56

wants to merge 2 commits into from

Conversation

minhhuy24072002
Copy link
Collaborator

No description provided.

DedsecKnight
DedsecKnight reviewed May 22, 2024
View reviewed changes
k8s/bsg-frontend.yaml Outdated
spec:
selector:
app: bsg-frontend
type: LoadBalancer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we're using LoadBalancer? Doesn't seem to be necessary since we only have 1 replica.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DedsecKnight DedsecKnight Awaiting requested review from DedsecKnight

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhhuy24072002 @DedsecKnight