-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freedns: fix domain splitting for multi-part domains #1454
Conversation
Does that also work if I have separate zone for a subdomain. |
I'm not entirely sure, are you able to test it? |
I never used freedns. |
This addresses the issue in #1086. As for checking each part in turn, that will need some testing. |
Fix inwx account without Mobile TAN
Fixes acmesh-official#1086 Supercedes acmesh-official#1454 Signed-off-by: Joe Groocock <[email protected]>
Fixes acmesh-official#1086 Supercedes acmesh-official#1454 Signed-off-by: Joe Groocock <[email protected]>
It seems that the way domains were split before was using some unnecessarily complex maths which was broken for domains >3 parts (e.g
_acme-challenge.test.domain.com
)I assume what the correct behaviour should be is the following:
This PR fixes for domains >3 parts and still works for simple
sub.domain.com
domains