Pass by value in MarshalXML.

[dtbartle]

This fixes XML marshaling when these types are embedded in structs as values (vs pointers). The specific use case I have is to store the raw XML values for later processing (and unmarshaling).

I don't think this fix is complete. For example, the InvTranList type has the same problem, though in practice it is always embedded in a struct by pointer. I think the XML parser could check for both the marshaler interface on the type and the marshier interface on the pointer to the type when iterating through structs.

[aclindsa]

In general, this looks reasonable to me, thanks for the contribution!

The specific use case I have is to store the raw XML values for later processing (and unmarshaling).

Just out of curiosity, why do you want/need to do this? I don't think I'd conceived of a need to do so.

I don't think this fix is complete. For example, the InvTranList type has the same problem, though in practice it is always embedded in a struct by pointer.

Are you saying you're planning to this in a future MR, or just suggesting it could hypothetically be done?

[dtbartle]

I have a personal finances project that tracks balances/transactions. I currently only use some of the information from the responses, but it felt nicer to save the XML in case I ever decide to pull in additional fields in the future.

I wasn't going to make subsequent fixes; changing some large structs to be value receivers would, I think, mean we'd be copying larger structs a bunch for marshaling (though maybe this is fine, as probably nobody is using OFX for high-performance stuff).

[aclindsa]

Neat. And sounds good, thanks!