Realease ReadableStream reader lock#12
Conversation
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
LGTM, just a few inline comments.
packages/it-multipart/test.js
Outdated
|
|
||
| server = http.createServer((req, res) => { | ||
| if (req.method === 'POST' && | ||
| // @ts-ignore - header may not be present |
There was a problem hiding this comment.
If it's not present this will error so it should null-guard
There was a problem hiding this comment.
I did not bother because it's a test and all request will have it.
|
It would have been better to split the release-lock PR out from the types PR, the two things are not related. |
They were independent already, as per PR description:
I was hoping that #9 would land first, in which case this would contain no type related changes. I did however added few commits to address some of the feedback that was not related to release lock, but I'll cherry-pick them into #9 as well. |
|
Fixed in 4480ea1 |
2 participants
This fixes #8 and is based on #9. Actual changes are in last commit.