Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Significant Improvements to Query, ImageQuery and Cookie helper classes #507

Closed
wants to merge 4 commits into from

Conversation

PFython
Copy link
Contributor

@PFython PFython commented Jun 6, 2023

These are all imported from BingChatUtils.py

I've added that to py_modules in setup.py - please revert or amend as necessary so that people can simple access as per the updated README file i.e. from BingChatUtils import Query

Hopefully closes issues:

#476
#473
#462

@PFython PFython changed the title Improvements to Query, ImageQuery and Cookie helper classes Significant Improvements to Query, ImageQuery and Cookie helper classes Jun 6, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a .py extension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - that'll teach me for manually renaming in Github in a hurry. Fixed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed

@acheong08
Copy link
Owner

BingChatUtils

I would prefer it to remain EdgeUtils

@PFython
Copy link
Contributor Author

PFython commented Jun 8, 2023

No problem - done.

@acheong08
Copy link
Owner

Conflicts

@acheong08
Copy link
Owner

Should I resolve these conflicts manually and merge? Is it still a draft?

CC: @JimouChen @StolenGalaxy @starhui70520

@JimouChen
Copy link

Should I resolve these conflicts manually and merge? Is it still a draft?

CC: @JimouChen @StolenGalaxy @starhui70520

Done

@acheong08 acheong08 marked this pull request as ready for review June 12, 2023 16:49
Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seriously can't merge. Way to many conflicts

@PFython
Copy link
Contributor Author

PFython commented Jun 12, 2023

No worries - I see several other changes. I'm happy to sort this out, just need a little time. All the best, Pete

@PFython PFython force-pushed the master branch 2 times, most recently from 9aabcfa to f5043c8 Compare July 7, 2023 12:45
@PFython PFython closed this Jul 7, 2023
@acheong08
Copy link
Owner

I resolved and merged in 5756789

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants