Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDB_Page] Add default maxYear for date elements #9498

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Dec 3, 2024

Brief summary of changes

  • Changed NDB_Page to have a default maxYear that is set for all date elements to '9999' if the page does not override that field with its own dateOptions

Testing instructions (if applicable)

  1. Open user accounts and edit a user, confirm that you can edit the Active To and Active From dates, and that it does not let you enter a year greater than 9999 anymore.

Link(s) to related issue(s)

@skarya22 skarya22 added the Language: PHP PR or issue that update PHP code label Dec 3, 2024
@maximemulder maximemulder added Category: Bug PR or issue that aims to report or fix a bug Area: UI PR or issue related to the user interface and removed Area: UI PR or issue related to the user interface labels Dec 3, 2024
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 4eb8f6c into aces:main Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Language: PHP PR or issue that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some dates allowing 6 digits in year
4 participants